Thanks for all the additional discussion and context. I wasn't aware of what a shaky ground we were on here today. I agree with the conclusion that we should firm it up somewhat before shipping this new API. So consider my LGTM rescinded for now. But please come back once you feel the highlighting foundation is solid enough to be safe to build upon.
On Thu, Sep 2, 2021 at 7:09 AM Manuel Rego Casasnovas <r...@igalia.com> wrote: > > > On 18/08/2021 18:15, Delan Azabani wrote: > > I think it was a mistake for Blink to ship ::target-text in this kind of > > state, and given the wider range of use cases that ::highlight aims to > > solve, I think it would be at least as much of a mistake here. > > I agree with this. > > ::target-text has a bunch of known issues, but sadly it's already shipped. > > But this is a way bigger API, that will allow web authors to add > highlights all over the page. It's a really nice one, but even limiting > it to color and background-color properties, there are a bunch of issues > that we should solve before shipping. Otherwise people could start to > depend on behaviors that are going to change (like inheritance), or find > that the API is not useful for some simple cases and discard it, or > whatever. > > We've collected examples that have issues in the current highlight > implementation: <https://codepen.io/dazabani13/pen/KKqzOJp> > > Delan has been working on adding support for ::spelling|grammar-error. > These pseudos have many of the same issues, as they use DocumentMarkers > like custom highlights. She has been fixing some of them, but the work > is still ongoing. Anyway probably not all the issues need to be fixed > before shipping. > > If you're interested, we've started writing a design doc that explores > the topic in more detail: > < > https://docs.google.com/document/d/1Rfelx4qv-RhQYHUJ74QBU5MjEbmb9Wol9gvyjkywqgE > > > > Cheers, > Rego > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/ed2ddcce-228e-94a4-7a6b-2ed3e1c52fed%40igalia.com > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY_0D1%3Dz-H%2B9fWST1J4_X80RVQseh_8axB0qEwZ%3DiGkkjw%40mail.gmail.com.
