Thanks all!
Shipping in 105 seems like a good target (branch date Thu, Jul 21, 2022). We still need HighlightOverlayPainting (https://chromium-review.googlesource.com/c/chromium/src/+/3640642) to reland first. I believe @Delan Azabani<mailto:dazab...@igalia.com>/@Manuel Rego Casasnovas<mailto:r...@igalia.com> are driving that change and may have a better idea of the timeline. I'll follow up with the CL to enable Highlight API as soon as that lands. -- Dan From: Joe Medley <jmed...@google.com> Sent: Wednesday, June 22, 2022 10:18 AM To: Daniel Bratell <bratel...@gmail.com> Cc: Yoav Weiss <yoavwe...@chromium.org>; blink-dev <blink-dev@chromium.org>; Daniel Clark <dan...@microsoft.com>; Manuel Rego <r...@igalia.com>; Sanket Joshi (EDGE) <sa...@microsoft.com>; Fernando Fiori <ffi...@microsoft.com>; Bo Cupp <pc...@microsoft.com>; Luis Juan Sanchez Padilla <luis.snc...@microsoft.com>; Delan Azabani <dazab...@igalia.com>; Rick Byers <rby...@chromium.org>; flo...@rivoal.net <flor...@rivoal.net> Subject: Re: [blink-dev] Intent to Ship: Custom Highlight API When do you hope to ship? Joe Medley | Technical Writer, Chrome DevRel | jmed...@google.com<mailto:jmed...@google.com> | 816-678-7195 If an API's not documented it doesn't exist. On Wed, Jun 22, 2022 at 9:26 AM Daniel Bratell <bratel...@gmail.com<mailto:bratel...@gmail.com>> wrote: With dual LGTM1 from Chris and Yoav, I'll jump directly to... LGTM3 /Daniel On 2022-06-22 17:58, Yoav Weiss wrote: LGTM1 On Wednesday, June 15, 2022 at 11:54:30 PM UTC+2 Daniel Clark wrote: > What's the feature detection/activation story here? Can developers use the > feature while it's partially supported? What would be the implications of > that? Feature detection can be done by checking for the presence of CSS.highlights: function supportsHighlightAPI() { return !!CSS.highlights; } For use cases where the highlights are key to the user experience (e.g. when used for an app’s custom find-on-page implementation), developers should fall back to a polyfill for unsupported browsers. For use cases where highlights are only added for stylistic purposes, they could be omitted altogether when there isn’t support. A polyfill could be built for the feature that works by wrapping “highlighted” content in styled spans. This could get tricky to implement for cases involving many nested highlights (which is one thing that the API makes much easier), but it would work fine for most scenarios. > We could send a ping notifying that Chromium is planning to ship. I pinged the mozilla/standards-positions thread about this last week, still waiting to hear back https://github.com/mozilla/standards-positions/issues/482#issuecomment-1152601522<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmozilla%2Fstandards-positions%2Fissues%2F482%23issuecomment-1152601522&data=05%7C01%7Cdaniec%40microsoft.com%7C3ab8d4cef9a44046d14808da547349d8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637915151411080842%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=glPRb8BtUD524TxbWkwV8PzP3ezVSpXEifMfgz5CWwE%3D&reserved=0>. @Emilio<mailto:emi...@mozilla.com>, is there anything you’d be able to share about this? > Can you ask for an explicit signal to see what their plans are on that front? > Is there an interop risk from their incomplete implementation? I sent a mail<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.webkit.org%2Fpipermail%2Fwebkit-dev%2F2022-June%2F032303.html&data=05%7C01%7Cdaniec%40microsoft.com%7C3ab8d4cef9a44046d14808da547349d8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637915151411080842%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=g68jJFyer6AjIVgtvzsUQeszBscscIldSZupfTrO2Mk%3D&reserved=0> to webkit-dev, awaiting response. I just took another look at their implementation, and they’ve done some work to bring it closer to the current state of the spec since last I checked. The remaining major difference I see is just the lack of support for live Ranges. I expect that they will close this gap prior to shipping the feature. If they don’t then the difference could also be feature-detected by polyfills: function supportsLiveRangeHighlights() { try { new Highlight(new Range()); return true; } catch(ex) { return false; }; } -- Dan From: Yoav Weiss <yoavwe...@chromium.org<mailto:yoavwe...@chromium.org>> Sent: Wednesday, June 15, 2022 1:32 AM To: blink-dev <blink-dev@chromium.org<mailto:blink-dev@chromium.org>> Cc: Manuel Rego <r...@igalia.com<mailto:r...@igalia.com>>; Sanket Joshi (EDGE) <sa...@microsoft.com<mailto:sa...@microsoft.com>>; Fernando Fiori <ffi...@microsoft.com<mailto:ffi...@microsoft.com>>; Bo Cupp <pc...@microsoft.com<mailto:pc...@microsoft.com>>; Luis Juan Sanchez Padilla <luis.snc...@microsoft.com<mailto:luis.snc...@microsoft.com>>; Delan Azabani <dazab...@igalia.com<mailto:dazab...@igalia.com>>; Emilio Cobos Alvarez <emi...@mozilla.com<mailto:emi...@mozilla.com>>; Rick Byers <rby...@chromium.org<mailto:rby...@chromium.org>>; flo...@rivoal.net<mailto:flo...@rivoal.net> <flor...@rivoal.net<mailto:flor...@rivoal.net>>; Daniel Clark <dan...@microsoft.com<mailto:dan...@microsoft.com>> Subject: Re: [blink-dev] Intent to Ship: Custom Highlight API On Thursday, June 9, 2022 at 6:55:06 AM UTC+2 Manuel Rego wrote: I'm biased here as I've been working on this feature myself, so I cannot give an official LGTM. Thanks for all the work since the previous intent thread, I believe this is now in a way better status to ship. I'd be fine giving a LGTM with the following caveats: * As mentioned at the end of the email, HighlightOverlayPainting flag gets enabled before shipping this (that flag fixes lots of bugs regarding paining of CSS highlight pseudos). * The following CSSWG issue gets resolved: https://github.com/w3c/csswg-drafts/issues/6774<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fw3c%2Fcsswg-drafts%2Fissues%2F6774&data=05%7C01%7Cdaniec%40microsoft.com%7C3ab8d4cef9a44046d14808da547349d8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637915151411080842%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=PoHUWPF%2B%2F%2Fm1HU7NYPYZxsJMWJt9HdPxHGbkdL31yC4%3D&reserved=0> It looks like there's an agreement already but it'd be nice to confirm it, as this might change behavior if a different decision is made. Other than that I've just some minor comments inline. On 08/06/2022 19:42, 'Daniel Clark' via blink-dev wrote: > Risks > > > Interoperability and Compatibility > > Low risk: This feature received positive support from Safari and Firefox > at TPAC 2019. Safari is implementing it, Firefox has not yet made any > clear indication on implementation. What's the feature detection/activation story here? Can developers use the feature while it's partially supported? What would be the implications of that? > > > > /Gecko/: No clear signal > (https://github.com/mozilla/standards-positions/issues/482<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmozilla%2Fstandards-positions%2Fissues%2F482&data=05%7C01%7Cdaniec%40microsoft.com%7C3ab8d4cef9a44046d14808da547349d8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637915151411080842%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2FuU8uekd%2FwJwyVcTdjR3%2FsYYQr%2FZ4FsZan6wEbdJZgM%3D&reserved=0> > <https://github.com/mozilla/standards-positions/issues/482<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmozilla%2Fstandards-positions%2Fissues%2F482&data=05%7C01%7Cdaniec%40microsoft.com%7C3ab8d4cef9a44046d14808da547349d8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637915151411080842%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2FuU8uekd%2FwJwyVcTdjR3%2FsYYQr%2FZ4FsZan6wEbdJZgM%3D&reserved=0>>) We could send a ping notifying that Chromium is planning to ship. > /WebKit/: Positive. WebKit implemented the feature behind an > experimental flag in 99: > https://developer.apple.com/safari/technology-preview/release-notes/#:~:text=Added%20support%20for%20rendering%20highlights%20specified%20in%20CSS%20Highlight%20API<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdeveloper.apple.com%2Fsafari%2Ftechnology-preview%2Frelease-notes%2F%23%3A~%3Atext%3DAdded%2520support%2520for%2520rendering%2520highlights%2520specified%2520in%2520CSS%2520Highlight%2520API&data=05%7C01%7Cdaniec%40microsoft.com%7C3ab8d4cef9a44046d14808da547349d8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637915151411080842%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=gUFrWdDxg%2Bv3nZApKFHs3XZYStpprO8Gk8%2B4DDoKhSc%3D&reserved=0> > <https://developer.apple.com/safari/technology-preview/release-notes/#:~:text=Added%20support%20for%20rendering%20highlights%20specified%20in%20CSS%20Highlight%20API<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdeveloper.apple.com%2Fsafari%2Ftechnology-preview%2Frelease-notes%2F%23%3A~%3Atext%3DAdded%2520support%2520for%2520rendering%2520highlights%2520specified%2520in%2520CSS%2520Highlight%2520API&data=05%7C01%7Cdaniec%40microsoft.com%7C3ab8d4cef9a44046d14808da547349d8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637915151411080842%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=gUFrWdDxg%2Bv3nZApKFHs3XZYStpprO8Gk8%2B4DDoKhSc%3D&reserved=0>>. I agree that it's positive WebKit has a WIP implementation. But just to clarify the status Safari has an old version of this spec implemented, and the implementation is not complete and not up to date regarding the spec (e.g. https://bugs.webkit.org/show_bug.cgi?id=229797<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.webkit.org%2Fshow_bug.cgi%3Fid%3D229797&data=05%7C01%7Cdaniec%40microsoft.com%7C3ab8d4cef9a44046d14808da547349d8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637915151411237077%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=y%2FEfD%2BID2UokWpodtYhGmALgxHKyyujqlJdUkABX9dY%3D&reserved=0>). Can you ask for an explicit signal to see what their plans are on that front? Is there an interop risk from their incomplete implementation? Cheers, Rego -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org<mailto:blink-dev+unsubscr...@chromium.org>. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/5947b08e-67d2-45bf-a468-c78b619de02fn%40chromium.org<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fa%2Fchromium.org%2Fd%2Fmsgid%2Fblink-dev%2F5947b08e-67d2-45bf-a468-c78b619de02fn%2540chromium.org%3Futm_medium%3Demail%26utm_source%3Dfooter&data=05%7C01%7Cdaniec%40microsoft.com%7C3ab8d4cef9a44046d14808da547349d8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637915151411237077%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=evI8jibcUEyzVnwNRdL5lUmAub3E%2FcsmdK%2BJ5uBNlzs%3D&reserved=0>. -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org<mailto:blink-dev+unsubscr...@chromium.org>. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/caf614ae-f018-89d2-a28b-b02425d49927%40gmail.com<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fa%2Fchromium.org%2Fd%2Fmsgid%2Fblink-dev%2Fcaf614ae-f018-89d2-a28b-b02425d49927%2540gmail.com%3Futm_medium%3Demail%26utm_source%3Dfooter&data=05%7C01%7Cdaniec%40microsoft.com%7C3ab8d4cef9a44046d14808da547349d8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637915151411237077%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=isQbESNcdYasiNYooffZBGHJZmk4BM1xvJjOZu7Qlew%3D&reserved=0>. -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/SN6PR00MB044830CB74DB0E93ED948FD8C5B29%40SN6PR00MB0448.namprd00.prod.outlook.com.
