It's great to see this feature getting ready to ship, it's one of a relatively small number of features already supported by Firefox and Safari but not by Chromium browsers, so it's been on my radar :)
I just have a few questions. Looking at the font-synthesis-* tests in https://wpt.fyi/results/css/css-fonts?label=experimental&label=master&aligned, many pass in Firefox and Safari, but not all of them. Do all of these tests pass with the implementation now in Blink? In the chromestatus entry I see "There are additional tests for system fonts with platform specific results, so we keep those as internal tests." Is the problem there that the tests rely on system fonts, or that there are platform-specific results? The latter is possible with WPT using the regular third_party/blink/web_tests/platform/ expectations. For system fonts, perhaps these tests could be written to pass if the fonts aren't present? If these are testharness.js tests, https://web-platform-tests.org/writing-tests/testharness-api.html#optional-features might be a path forward. Also, looking at https://developer.mozilla.org/en-US/docs/Web/CSS/font-synthesis#browser_compatibility I wonder if small-caps is going to be supported? If that table is correct it's not supported by Safari and it's only just now coming to Firefox. On Thu, Oct 7, 2021 at 9:59 AM Daniel Bratell <bratel...@gmail.com> wrote: > LGTM2 > > /Daniel > On 2021-10-07 09:08, Yoav Weiss wrote: > > *LGTM1* > Thanks for working on this!! This seems like an important thing to catch > up on! > > > > On Tue, Oct 5, 2021 at 6:56 PM 'Munira Tursunova' via blink-dev < > blink-dev@chromium.org> wrote: > >> Contact emails >> >> moon...@google.com, dr...@chromium.org >> >> Explainer >> >> https://drafts.csswg.org/css-fonts-4/#font-synthesis-intro >> >> https://developer.mozilla.org/en-US/docs/Web/CSS/font-synthesis >> >> Specification >> >> https://drafts.csswg.org/css-fonts/#font-synthesis >> >> Summary >> >> The font-synthesis CSS property controls whether user agents are allowed >> to synthesize oblique, bold and small-caps font faces when a font family >> lacks oblique, bold and small-caps faces, respectively. >> >> >> Blink component >> >> Blink>Fonts >> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EFonts> >> >> TAG review status >> >> Already shipped in other browsers, see below, no TAG review required. >> >> Risks >> >> Interoperability and Compatibility Low, feature already shipped in >> Firefox and Safari. >> >> Expected graceful degradation if an engine has so far not implemented >> this feature: if the font-synthesis: property is not understood by an >> engine, this means unintended synthesis can occur. That's expected and the >> reason why this property was designed. >> >> Signals >> >> Gecko: Shipped/Shipping ( >> https://developer.mozilla.org/en-US/docs/Web/CSS/font-synthesis#browser_compatibility) >> https://bugzilla.mozilla.org/show_bug.cgi?id=1706080 >> >> WebKit: Shipped/Shipping (https://bugs.webkit.org/show_bug.cgi?id=144180) >> >> Web developers: No signals >> >> Activation >> >> None expected, feature already implemented in other browsers. >> >> >> Debuggability >> >> Same as any other CSS property, css_properties.json will be rolled to >> DevTools during development. >> >> >> Is this feature fully tested by web-platform-tests >> <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md> >> ? >> >> Yes, 36 new web tests pass: 16 new internal platform specific tests were >> added, 12 new WPT tests were added and 8 existing WPT tests are now passing. >> >> >> Requires code in //chrome? >> >> False >> >> Tracking bug >> >> https://bugs.chromium.org/p/chromium/issues/detail?id=509989 >> >> Sample links >> >> https://drafts.csswg.org/css-fonts-4/#font-synthesis-intro >> >> Estimated milestones >> >> No milestones specified >> >> >> Link to entry on the Chrome Platform Status >> >> https://www.chromestatus.com/feature/5640605355999232 >> >> This intent message was generated by Chrome Platform Status >> <https://www.chromestatus.com/>. >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAAO7W_AmPR6X7evqGz9P7bkW2ysRmr%3DqP4ajgGA%2BjOGfsp_FrA%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAAO7W_AmPR6X7evqGz9P7bkW2ysRmr%3DqP4ajgGA%2BjOGfsp_FrA%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfXyqaq60U%2BEzTWxYLhhZcW%3DyjZMetHjkgfmjpWibOWLxg%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfXyqaq60U%2BEzTWxYLhhZcW%3DyjZMetHjkgfmjpWibOWLxg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/948ab999-2298-be47-ecab-d9585ea31b22%40gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/948ab999-2298-be47-ecab-d9585ea31b22%40gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYdAgP%2BCauo3SC54RAikfKdomGv23J5aPTxAsdLnT4FJ6g%40mail.gmail.com.
