Thank you for the thoughtful reviews! On Wed, Jun 8, 2022 at 9:21 AM Chris Harrelson <chris...@chromium.org> wrote:
> LGTM3 > > On Wed, Jun 8, 2022 at 8:58 AM Yoav Weiss <yoavwe...@chromium.org> wrote: > >> LGTM2 >> >> On Wed, Jun 8, 2022 at 5:57 PM Mike Taylor <miketa...@chromium.org> >> wrote: >> >>> LGTM1 >>> >>> On 6/8/22 11:46 AM, Mike Wasserman wrote: >>> >>> The PR <https://github.com/w3c/window-placement/pull/101> has been >>> merged into the latest Multi-Screen Window Placement Editor's Draft >>> <https://w3c.github.io/window-placement/#usage-overview-initiate-multi-screen-experiences>; >>> thanks. >>> >>> On Wed, Jun 8, 2022 at 2:09 AM Mike Wasserman <m...@chromium.org> wrote: >>> >>>> A requested reviewer has been short on time recently (OOO, work travel, >>>> holiday). I sent a friendly ping. >>>> >>>> >>>> On Wed, Jun 8, 2022 at 12:01 AM Yoav Weiss <yoavwe...@chromium.org> >>>> wrote: >>>> >>>>> What's blocking the PR from landing? >>>>> >>>>> On Thursday, May 26, 2022 at 12:01:24 AM UTC+2 Mike Wasserman wrote: >>>>> >>>>>> Thanks for asking! Here is an initial draft PR, now out for review: < >>>>>> https://github.com/w3c/window-placement/pull/101> >>>>>> An alternate formulation might extend HTML's Tracking User Activation >>>>>> models < >>>>>> https://html.spec.whatwg.org/multipage/interaction.html#tracking-user-activation> >>>>>> and refine the use of those models in individual APIs. >>>>>> >>>>>> On Wed, May 25, 2022 at 1:55 AM Yoav Weiss <yoavwe...@chromium.org> >>>>>> wrote: >>>>>> >>>>>>> >>>>>>> >>>>>>> On Tuesday, May 10, 2022 at 2:35:40 AM UTC+2 Mike Wasserman wrote: >>>>>>> >>>>>>>> Contact emails >>>>>>>> >>>>>>>> m...@chromium.org >>>>>>>> >>>>>>>> >>>>>>>> Explainer >>>>>>>> >>>>>>>> >>>>>>>> https://github.com/w3c/window-placement/blob/main/EXPLAINER_initiating_multi_screen_experiences.md >>>>>>>> >>>>>>>> Specification >>>>>>>> >>>>>>>> >>>>>>>> https://github.com/w3c/window-placement/blob/main/EXPLAINER_initiating_multi_screen_experiences.md#spec-changes >>>>>>>> >>>>>>> >>>>>>> Are there PRs that define the new processing models for this? >>>>>>> >>>>>>> >>>>>>>> >>>>>>>> Design docs >>>>>>>> >>>>>>>> >>>>>>>> https://docs.google.com/document/d/1RRlGQharWVnmxKTomfKhNiaeE31L7iXHeXVfifOvwJA >>>>>>>> >>>>>>>> Summary >>>>>>>> >>>>>>>> Fullscreen Companion Window allows sites to place fullscreen >>>>>>>> content and a popup window on separate screens from a single user >>>>>>>> activation. >>>>>>>> >>>>>>>> This is a small requested enhancement of the Multi-Screen Window >>>>>>>> Placement feature: >>>>>>>> https://chromestatus.com/feature/5252960583942144 >>>>>>>> >>>>>>>> Blink component >>>>>>>> >>>>>>>> Blink>Screen>MultiScreen >>>>>>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EScreen%3EMultiScreen> >>>>>>>> >>>>>>>> TAG review >>>>>>>> >>>>>>>> >>>>>>>> https://github.com/w3ctag/design-reviews/issues/602#issuecomment-1121694034 >>>>>>>> >>>>>>>> TAG review status >>>>>>>> >>>>>>>> Pending >>>>>>>> >>>>>>>> Risks >>>>>>>> Interoperability and Compatibility >>>>>>>> >>>>>>>> The main risk is that this feature fails to become an interoperable >>>>>>>> part of the web platform if other browsers do not implement it. >>>>>>>> Scripted >>>>>>>> attempts to open a popup window after requesting fullscreen would >>>>>>>> likely be >>>>>>>> blocked by user agents that do not implement this feature, even if they >>>>>>>> implement the basic Multi-Screen Window Placement API. >>>>>>>> >>>>>>>> Gecko: No signal ( >>>>>>>> https://github.com/mozilla/standards-positions/issues/636) >>>>>>>> >>>>>>>> WebKit: No signal ( >>>>>>>> https://lists.webkit.org/pipermail/webkit-dev/2022-May/032223.html) >>>>>>>> >>>>>>>> Web developers: Positive ( >>>>>>>> https://bugs.chromium.org/p/chromium/issues/detail?id=1233970) >>>>>>>> This functionality is requested by a prominent API partner >>>>>>>> >>>>>>>> Ergonomics >>>>>>>> >>>>>>>> There is currently no way to detect feature support before >>>>>>>> attempted usage; see >>>>>>>> https://docs.google.com/document/d/1RRlGQharWVnmxKTomfKhNiaeE31L7iXHeXVfifOvwJA/edit?pli=1#heading=h.vu2lz7aeddz6 >>>>>>>> >>>>>>>> Activation >>>>>>>> >>>>>>>> Developers can make immediate use of this API enhancement. >>>>>>>> >>>>>>>> Security >>>>>>>> >>>>>>>> This feature was designed from the ground-up to adhere to the >>>>>>>> strictest usable security measures possible, as an incremental >>>>>>>> enhancement >>>>>>>> of existing web platform APIs. See the design document for details. >>>>>>>> >>>>>>>> WebView application risks >>>>>>>> >>>>>>>> None >>>>>>>> >>>>>>>> Debuggability >>>>>>>> >>>>>>>> Existing mechanisms support debugging fullscreen and popup window >>>>>>>> open requests. >>>>>>>> >>>>>>>> Is this feature fully tested by web-platform-tests >>>>>>>> <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md> >>>>>>>> ? >>>>>>>> >>>>>>>> No. An existing automated/manual WPT covers the ability to open >>>>>>>> cross-screen popups <https://wpt.live/window-placement>. We aim to >>>>>>>> extend test coverage for this specific scenario soon < >>>>>>>> https://crbug.com/1323361>. >>>>>>>> >>>>>>>> DevTrial instructions >>>>>>>> >>>>>>>> https://github.com/w3c/window-placement/blob/main/HOWTO.md >>>>>>>> >>>>>>>> Flag name >>>>>>>> >>>>>>>> --enable-blink-features=WindowPlacement >>>>>>>> >>>>>>>> Requires code in //chrome? >>>>>>>> >>>>>>>> True - >>>>>>>> https://docs.google.com/spreadsheets/d/1QV4SW4JBG3IyLzaonohUhim7nzncwK4ioop2cgUYevw/edit#gid=0&range=34:34 >>>>>>>> >>>>>>>> Tracking bug >>>>>>>> >>>>>>>> https://crbug.com/1233970 >>>>>>>> >>>>>>>> Launch bug >>>>>>>> >>>>>>>> https://crbug.com/1315615 >>>>>>>> >>>>>>>> Sample links >>>>>>>> >>>>>>>> https://michaelwasserman.github.io/window-placement-demo/ >>>>>>>> >>>>>>>> (See DevTrial instructions) >>>>>>>> >>>>>>>> Estimated milestones >>>>>>>> >>>>>>>> DevTrial on desktop: 102 >>>>>>>> >>>>>>>> Shipping on desktop: 103 >>>>>>>> >>>>>>>> Anticipated spec changes >>>>>>>> >>>>>>>> No changes anticipated that would introduce web compat/interop risk >>>>>>>> >>>>>>>> Link to entry on the Chrome Platform Status >>>>>>>> >>>>>>>> https://chromestatus.com/feature/5173162437246976 >>>>>>>> >>>>>>>> Links to previous Intent discussions >>>>>>>> >>>>>>>> Intents for the Multi-Screen Window Placement API: >>>>>>>> >>>>>>>> - >>>>>>>> >>>>>>>> I2P: < >>>>>>>> https://groups.google.com/a/chromium.org/g/blink-dev/c/X6rEbWvU7cI >>>>>>>> > >>>>>>>> - >>>>>>>> >>>>>>>> I2E1: < >>>>>>>> https://groups.google.com/a/chromium.org/g/blink-dev/c/C6xw8i1ZIdE >>>>>>>> > >>>>>>>> - >>>>>>>> >>>>>>>> I2E2: < >>>>>>>> https://groups.google.com/a/chromium.org/g/blink-dev/c/jznxQK1U8ZQ >>>>>>>> > >>>>>>>> - >>>>>>>> >>>>>>>> I2S: < >>>>>>>> https://groups.google.com/a/chromium.org/g/blink-dev/c/i6Zoc7jU0dM >>>>>>>> > >>>>>>>> >>>>>>>> -- >>>>> You received this message because you are subscribed to a topic in the >>>>> Google Groups "blink-dev" group. >>>>> To unsubscribe from this topic, visit >>>>> https://groups.google.com/a/chromium.org/d/topic/blink-dev/Fv63upuTXMA/unsubscribe >>>>> . >>>>> To unsubscribe from this group and all its topics, send an email to >>>>> blink-dev+unsubscr...@chromium.org. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/03452ca2-a281-4c36-a188-ecb2ed33ef44n%40chromium.org >>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/03452ca2-a281-4c36-a188-ecb2ed33ef44n%40chromium.org?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAEsbcpU0L14DQC6R395xSHPB38dxh6Dg1RimtZfS-QBOi-vR5w%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAEsbcpU0L14DQC6R395xSHPB38dxh6Dg1RimtZfS-QBOi-vR5w%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >>> >>> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfV1Zew4v0NKW%2Bvrfn77EmrKvMvnTH9%3DGo-3uMwWwyQG5A%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfV1Zew4v0NKW%2Bvrfn77EmrKvMvnTH9%3DGo-3uMwWwyQG5A%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAEsbcpVY7d-DUMJUhVCTcri6PxzrdhMMLBi2tYZ9osvNhdqyig%40mail.gmail.com.