This feature is covered by integration tests. showDirectoryPicker() only has manual WPT coverage <https://crsrc.org/c/third_party/blink/web_tests/external/wpt/file-system-access/showDirectoryPicker-manual.https.html?q=showdirectorypicker>, and since this launch only corresponds to changes in permission prompt behavior, WPTs didn't really make sense.
On Wed, Jun 29, 2022 at 10:57 AM Chris Harrelson <chris...@chromium.org> wrote: > > > On Wed, Jun 29, 2022 at 7:52 AM Mike West <mk...@chromium.org> wrote: > >> LGTM2. Thank you for working with the permissions and UX teams to hammer >> out a reasonable approach here. >> >> -mike >> >> >> On Mon, Jun 27, 2022 at 4:40 PM 'Austin Sullivan' via blink-dev < >> blink-dev@chromium.org> wrote: >> >>> PR is landed >>> >>> On Fri, Jun 24, 2022 at 3:09 PM Austin Sullivan <asu...@google.com> >>> wrote: >>> >>>> I was waiting for approval on this I2S before landing, but clearly I >>>> had my order of operations inverted :) >>>> >>>> Also I could've sworn I was already in the WICG, but for some reason >>>> the IPR bot doesn't think I am. I've submitted another request... >>>> >>>> On Fri, Jun 24, 2022 at 11:49 AM Yoav Weiss <yoavwe...@chromium.org> >>>> wrote: >>>> >>>>> >>>>> >>>>> On Mon, Jun 13, 2022 at 1:58 PM 'Austin Sullivan' via blink-dev < >>>>> blink-dev@chromium.org> wrote: >>>>> >>>>>> Contact emailsasu...@chromium.org >>>>>> >>>>>> ExplainerNone >>>>>> >>>>>> Specificationhttps://github.com/WICG/file-system-access/pull/300 >>>>>> >>>>> >>>>> Anything preventing us from landing the PR? >>>>> >>>>> >>>>>> >>>>>> >>>>>> Summary >>>>>> >>>>>> Allow returning a directory with both read and write permissions in a >>>>>> single prompt for the File System Access API. Currently >>>>>> showDirectoryPicker() always returns a read-only directory (after >>>>>> showing a >>>>>> read access prompt), requiring a second permission prompt to get write >>>>>> access. This double-prompt is a poor user experience and contributes to >>>>>> confusion and permission fatigue among users. >>>>>> >>>>>> >>>>>> Adds an optional "mode" option to DirectoryPickerOptions which can be >>>>>> specified as "read" or "readwrite". >>>>>> >>>>>> >>>>>> Blink componentBlink>Storage>FileSystem >>>>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EStorage%3EFileSystem> >>>>>> >>>>>> TAG reviewWe did not seek a TAG review given the small scope of this >>>>>> feature. This launch does not add any new capabilities, but merely >>>>>> provides >>>>>> the browser with enough information to combine two permission prompts >>>>>> into >>>>>> one. >>>>>> >>>>>> TAG review statusN/A >>>>>> >>>>>> Risks >>>>>> >>>>>> >>>>>> Interoperability and Compatibility >>>>>> >>>>>> >>>>>> >>>>>> *Gecko*: No signal >>>>>> >>>>>> *WebKit*: No signal >>>>>> >>>>>> *Web developers*: Strongly positive ( >>>>>> https://github.com/WICG/file-system-access/issues/89) >>>>>> >>>>>> *Other signals*: >>>>>> >>>>>> WebView application risks >>>>>> >>>>>> Does this intent deprecate or change behavior of existing APIs, such >>>>>> that it has potentially high risk for Android WebView-based applications? >>>>>> >>>>>> No >>>>>> >>>>>> >>>>>> >>>>>> Debuggability >>>>>> >>>>>> N/A >>>>>> >>>>>> >>>>>> Will this feature be supported on all six Blink platforms (Windows, >>>>>> Mac, Linux, Chrome OS, Android, and Android WebView)?No - The File >>>>>> System Access API is not supported on Android >>>>>> >>>>>> Is this feature fully tested by web-platform-tests >>>>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>>>>> ?No >>>>>> >>>>> > Can you clarify? Is it tested via wpt-internal, because of the status of > the spec in WICG? Or is it not possible to test this feature via that kind > of mechanism? If so, is it instead tested via integration tests? > > >> >>>>>> >>>>>> Flag name >>>>>> >>>>>> Requires code in //chrome?False >>>>>> >>>>>> Tracking bughttps://crbug.com/1115632 >>>>>> >>>>>> Launch bughttps://crbug.com/1213159 >>>>>> >>>>>> Estimated milestones >>>>>> >>>>>> 105 >>>>>> >>>>>> >>>>>> Anticipated spec changes >>>>>> >>>>>> Open questions about a feature may be a source of future web compat >>>>>> or interop issues. Please list open issues (e.g. links to known github >>>>>> issues in the project for the feature specification) whose resolution may >>>>>> introduce web compat/interop risk (e.g., changing to naming or structure >>>>>> of >>>>>> the API in a non-backward-compatible way). >>>>>> >>>>>> >>>>>> Link to entry on the Chrome Platform Status >>>>>> https://chromestatus.com/feature/6383970247770112 >>>>>> >>>>>> This intent message was generated by Chrome Platform Status >>>>>> <https://chromestatus.com/>. >>>>>> >>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "blink-dev" group. >>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>> send an email to blink-dev+unsubscr...@chromium.org. >>>>>> To view this discussion on the web visit >>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADs-7rHzNmDAE89ZmOEBR5CNCGprOVUBasCjijADr1LxvAd_Qg%40mail.gmail.com >>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADs-7rHzNmDAE89ZmOEBR5CNCGprOVUBasCjijADr1LxvAd_Qg%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>> . >>>>>> >>>>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADs-7rEz2YSh35tGs_hq1ENBZsp-1Q3kVfEv19Chwbh8gjXTmw%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADs-7rEz2YSh35tGs_hq1ENBZsp-1Q3kVfEv19Chwbh8gjXTmw%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKXHy%3DeKR5jn7f%2BM5KB5%3DgvJR1bvsgZHRT3VRtTR7idC1AqU6w%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKXHy%3DeKR5jn7f%2BM5KB5%3DgvJR1bvsgZHRT3VRtTR7idC1AqU6w%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADs-7rEztSpx1n8CfmKsAuRS0jx7NoSetSkzX2HZjxPTgh4LTg%40mail.gmail.com.
