I've updated the signals on the feature for now, and will ask for WebKit's in the new Repo sometime between now and shipping.
On Tue, Mar 14, 2023 at 12:36 AM Yoav Weiss <yoavwe...@chromium.org> wrote: > > > On Mon, Mar 13, 2023 at 8:59 PM Alex Cooper <alcoo...@chromium.org> wrote: > >> FWIW, I think the signals aren't required for an I2P yet anyways just for >> an Intent to Ship? I'd pre filled them because I found them while looking >> for some other ancillary data. >> > > The signals are indeed not required. But since you've put in signals, they > need to be accurate :) > If you prefer postponing that request, I'm fine with "no signals" for the > I2P stage. > > >> >> On Mon, Mar 13, 2023 at 12:39 PM Yoav Weiss <yoavwe...@chromium.org> >> wrote: >> >>> >>> >>> On Mon, Mar 13, 2023 at 8:35 PM Alex Cooper <alcoo...@chromium.org> >>> wrote: >>> >>>> It's mainly that this is just not yet tested because it is not yet >>>> implemented. >>>> >>> >>> OK, cool! >>> >>> >>>> >>>> With regards to the signals, this is implementing a portion of a CR >>>> spec that we already have the bulk of the rest of the implementation for >>>> (and had previously asked for signals on); >>>> >>> >>> If you previously asked for signals for the broader feature that's >>> probably fine, but the link you posted didn't really have any I could find. >>> Do you mind linking to the positions directly? >>> >>> >>>> so asking for signals for this (and the other portions of the spec that >>>> we haven't yet implemented and will be covered by future Chromestatus >>>> entries) feels a bit spammy. I'm not sure what kind of direct link you'd >>>> like for the Web Developers signal? >>>> >>> >>> Any evidence that shows developer support: >>> https://goo.gle/developer-signals >>> >>> >>>> On Mon, Mar 13, 2023 at 12:23 PM Yoav Weiss <yoavwe...@chromium.org> >>>> wrote: >>>> >>>>> Thanks! A few questions/comments below.. >>>>> >>>>> On Mon, Mar 13, 2023 at 7:13 PM Alex Cooper <alcoo...@chromium.org> >>>>> wrote: >>>>> >>>>>> Contact emailsalcoo...@chromium.org, bial...@chromium.org >>>>>> >>>>>> ExplainerNone >>>>>> >>>>>> Specification >>>>>> https://immersive-web.github.io/webxr/#apply-the-nominal-frame-rate >>>>>> >>>>>> Summary >>>>>> >>>>>> Allows querying for the current target frame rate of the XR Session, >>>>>> querying for the frame rates that the session supports, and requesting a >>>>>> change to the target frame rate. >>>>>> >>>>>> >>>>>> Blink componentBlink>WebXR >>>>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EWebXR> >>>>>> >>>>>> Motivation >>>>>> >>>>>> >>>>>> >>>>>> Initial public proposal >>>>>> >>>>>> TAG reviewhttps://github.com/w3ctag/design-reviews/issues/545 >>>>>> https://github.com/w3c/transitions/issues/420 >>>>>> >>>>>> TAG review statusIssues addressed >>>>>> >>>>>> Risks >>>>>> >>>>>> >>>>>> Interoperability and Compatibility >>>>>> >>>>>> >>>>>> >>>>>> *Gecko*: Positive (https://chromestatus.com/feature/5680169905815552) >>>>>> Re-using signals from overall WebXR API chromestatus entry ( >>>>>> https://chromestatus.com/feature/5680169905815552), since this is a >>>>>> part of the CR for that API that we haven't implemented yet. >>>>>> >>>>>> *WebKit*: No signal ( >>>>>> https://chromestatus.com/feature/5680169905815552) Re-using signals >>>>>> from overall WebXR API chromestatus entry ( >>>>>> https://chromestatus.com/feature/5680169905815552), since this is a >>>>>> part of the CR for that API that we haven't implemented yet. >>>>>> >>>>> >>>>> Neither really counts as a signal. Can you follow >>>>> https://bit.ly/blink-signals and file standard positions on both? >>>>> >>>>> >>>>>> >>>>>> *Web developers*: Strongly positive ( >>>>>> https://chromestatus.com/feature/5680169905815552) Re-using signals >>>>>> from overall WebXR API chromestatus entry ( >>>>>> https://chromestatus.com/feature/5680169905815552), since this is a >>>>>> part of the CR for that API that we haven't implemented yet. >>>>>> >>>>> >>>>> Can you please provide a direct link? >>>>> >>>>> >>>>>> >>>>>> *Other signals*: >>>>>> >>>>>> WebView application risks >>>>>> >>>>>> Does this intent deprecate or change behavior of existing APIs, such >>>>>> that it has potentially high risk for Android WebView-based applications? >>>>>> >>>>>> >>>>>> >>>>>> Debuggability >>>>>> >>>>>> >>>>>> >>>>>> Is this feature fully tested by web-platform-tests >>>>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>>>>> ?No >>>>>> >>>>> >>>>> Why not? Or will it be tested? (and is just not yet tested) >>>>> >>>>> >>>>>> >>>>>> >>>>>> Flag name >>>>>> >>>>>> Requires code in //chrome?False >>>>>> >>>>>> Tracking bughttps://crbug.com/1377432 >>>>>> >>>>>> Estimated milestones >>>>>> >>>>>> No milestones specified >>>>>> >>>>>> >>>>>> Link to entry on the Chrome Platform Status >>>>>> https://chromestatus.com/feature/5157293366181888 >>>>>> >>>>>> This intent message was generated by Chrome Platform Status >>>>>> <https://chromestatus.com/>. >>>>>> >>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "blink-dev" group. >>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>> send an email to blink-dev+unsubscr...@chromium.org. >>>>>> To view this discussion on the web visit >>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGOLbz36QHGLYyz2H_6CnsuiwN_y002YRg%2BCeWzs_dvPxhLEWg%40mail.gmail.com >>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGOLbz36QHGLYyz2H_6CnsuiwN_y002YRg%2BCeWzs_dvPxhLEWg%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>> . >>>>>> >>>>> -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGOLbz2s0_QxUnqOy26YWXcdZc4rDX0WYWLnVmNsgyFiJdDg_A%40mail.gmail.com.
