LGTM3 On Wed, Jul 19, 2023 at 8:54 AM Daniel Bratell <bratel...@gmail.com> wrote:
> LGTM2 > > /Daniel > On 2023-07-18 22:06, 'Rick Byers' via blink-dev wrote: > > Sounds good, thanks! I defer to your judgement on the future compat risk. > Worst case "*" has to be redefined not to include "executionContexts", but > that wouldn't be the ugliest wart in the web :-) > > LGTM1 > > On Tue, Jul 18, 2023 at 2:28 PM Ari Chivukula <aric...@chromium.org> > wrote: > >> Replies inline. >> ~ Ari Chivukula (Their/There/They're) >> >> >> On Tue, Jul 18, 2023 at 1:59 PM Rick Byers <rby...@google.com> wrote: >> >>> Seems like a pretty tiny addition to an already shipped feature. Just >>> one question on future compat: >>> >>> On Mon, Jul 17, 2023 at 7:34 AM Ari Chivukula <aric...@chromium.org> >>> wrote: >>> >>>> Contact emails >>>> >>>> aric...@chromium.org, miketa...@chromium.org, yoavwe...@chromium.org >>>> >>>> Specification >>>> >>>> https://w3c.github.io/webappsec-clear-site-data/ >>>> >>>> Summary >>>> >>>> Websites will now be able to clear all storage targets (“cookies”, >>>> “cache”, and “storage”) by sending `Clear-Site-Data: “*”`. Note that Chrome >>>> does not support clearing “executionContexts” at the moment, but if we >>>> added it in the future any header targeting “*” would then clear them too. >>>> >>> >>> What's the risk we'll find we can't actually do that for web compat >>> reasons? Eg. sites deploying "*" today without appreciating the >>> implications of asking for pages to be reloaded, then when we add >>> "executionContexts" support in the future the user experience degrades >>> enough that we can't actually ship it as part of the "*" set? Do we have >>> guidance for developers on when to use "*" vs. a specific list? >>> >> >> That's a reasonable question, so I could see adding a note in the spec so >> developers are forewarned. The danger seems less compatibility and more >> performance (if new methods take significant time) as anyone sending "*" >> should assume no prior state for that page is retained. >> >> >>> >>> Note: This was proposed in 2017, but never launched in Chrome. >>>> >>>> Blink component >>>> >>>> Blink>Storage >>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component%3ABlink%3EStorage> >>>> >>>> Motivation >>>> >>>> If a website really wanted to clear all data they would have to list >>>> all possible targets in the header and be sure to check if any were added >>>> in the future. By using “*” as the target, a website can be sure all data >>>> the browser supports to clear via the header will be cleared. >>>> >>>> TAG review >>>> >>>> https://github.com/w3ctag/design-reviews/issues/62 >>>> >>>> >>>> Compatibility & Interoperability >>>> >>>> We would be the first to implement if approved. >>>> >>> >>> Does Firefox (and older Chrome) just ignore the "*" token today? I.e. >>> can developers list a set of tokens along with "*" in order to use this >>> compatibly on both Chrome and Firefox? >>> >> >> Firefox seems to support it >> https://github.com/mozilla/gecko-dev/blame/master/toolkit/components/clearsitedata/ClearSiteData.cpp#L243 >> but Chrome ignores it >> https://source.chromium.org/chromium/chromium/src/+/main:content/browser/browsing_data/clear_site_data_handler.cc;drc=6b23c6773893d03431973aaa53ec9305c02bfeb8;l=268. >> In both cases you can list * with other targets for backwards compatibility. >> >> >>> >>> Gecko: Positive >>>> <https://github.com/mozilla/standards-positions/issues/90> >>>> >>>> >>>> WebKit: No current support >>>> <https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Clear-Site-Data> >>>> >>>> >>>> Web Developers: None so far >>>> >>>> Is this feature fully tested by web-platform-tests? >>>> >>>> >>>> https://wpt.fyi/results/client-hints/clear-site-data?label=experimental&label=master&aligned >>>> >>>> >>>> https://wpt.fyi/results/clear-site-data?label=experimental&label=master&aligned >>>> >>>> >>>> Tracking bug >>>> >>>> https://crbug.com/1464260 >>>> >>>> Link to entry on the Chrome Platform Status >>>> >>>> https://chromestatus.com/feature/5074132743487488 >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "blink-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to blink-dev+unsubscr...@chromium.org. >>>> To view this discussion on the web visit >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGpy5DLiBdF2iFZxhr7Uu0HEm6NtickKF2T_D1nvymYCCuV%3DHQ%40mail.gmail.com >>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGpy5DLiBdF2iFZxhr7Uu0HEm6NtickKF2T_D1nvymYCCuV%3DHQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY8S4erdt0A6NnZ%2B%3Dkqj589%3Dxb7Oumk%3D2j4_3aQ9p5%2Bitg%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY8S4erdt0A6NnZ%2B%3Dkqj589%3Dxb7Oumk%3D2j4_3aQ9p5%2Bitg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/fed5dc9b-4ea3-185d-4039-c1cd33578abf%40gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/fed5dc9b-4ea3-185d-4039-c1cd33578abf%40gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw9i75Ym4A%2B7u0wykJTPfusBxEdGDtb-Hqbo204RqtTJ9w%40mail.gmail.com.
