Good point, thanks for asking. Technically speaking, we can't write any tests because the language-specific content analysis is UA defined. Tests use common and easy words that most engines would analyze the same way, but you're right that we may need to modify tests if any engine analyzes them differently.
Tests contain that in comments, like this <https://github.com/web-platform-tests/wpt/blob/master/css/css-text/word-break/auto-phrase/word-break-auto-phrase-001.html> or this <https://github.com/web-platform-tests/wpt/blob/master/css/css-text/word-break/auto-phrase/word-break-auto-phrase-wbr-nobr-001.html>. I'm also talking to WebKit about tests, since there are currently two known engines; one in ICU and one in macOS/iOS. We'll work together to ensure words in tests are common and easy enough for both engines. Four tests failing is strange, thanks for pointing them out too, they all pass in Chromium bots. I'll check them and make sure they're all green before shipping. On Thu, Sep 7, 2023 at 1:00 AM Philip Jägenstedt <foo...@chromium.org> wrote: > Hi Koji, > > It looks like the tests for this are here: > > https://wpt.fyi/results/css/css-text/word-break/auto-phrase?label=experimental&label=master&aligned > > Since the implementation uses a heuristic and the spec doesn't define the > precise rules, can you say something about the approach taken in the tests? > Did you pick examples that are very easy to get right, so that we can > expect all implementations to pass these tests? > > There are still four tests failing, do you expect to fix those before > shipping? > > Best regards, > Philip > > On Fri, Sep 1, 2023 at 5:29 PM Koji Ishii <ko...@chromium.org> wrote: > >> On Fri, Sep 1, 2023 at 11:53 PM Mike Taylor <miketa...@chromium.org> >> wrote: >> >>> *Gecko*: No signal >>> >>> Can we request one? >>> >> >> Done, https://github.com/mozilla/standards-positions/issues/877 >> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAHe_1dJmbVodgZLXs%2BY43R%3DGKMKqWGWcadP3K-XOA0Mg%3DM%3DsvA%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAHe_1dJmbVodgZLXs%2BY43R%3DGKMKqWGWcadP3K-XOA0Mg%3DM%3DsvA%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAHe_1d%2BR9qrvNbzLK3z8U%2BKzAcbUSDEUvVCsMgaTXDZ9p0BfDg%40mail.gmail.com.
