LGTM2 On Wed, Oct 4, 2023 at 10:46 PM Yoav Weiss <yoavwe...@chromium.org> wrote:
> LGTM1 > > On Wed, Oct 4, 2023 at 7:17 PM Alex Turner <ale...@chromium.org> wrote: > >> Mike: thanks for the clarification, I've added a comment to the TAG >> review and kicked off those reviews in a new entry: >> https://chromestatus.com/feature/5148973702840320. I'll ping this thread >> when those reviews are complete. >> >> Yoav: yes, that's our understanding (although until enrollment is >> enforced there is a chance we don't have a complete view of the testers). >> We're in touch with a few partners who are using it that we will >> communicate to directly. We also have a mailing list to broadcast these >> kinds of updates more generally. Given that, we feel confident the impact >> will be minimal to those testing the API. >> >> Alex >> >> On Wed, Oct 4, 2023 at 6:50 AM Yoav Weiss <yoavwe...@chromium.org> wrote: >> >>> Am I right to assume that the API is still only being used by a >>> relatively small number of partners to which y'all can communicate the new >>> constraints? >>> >>> On Monday, October 2, 2023 at 11:08:43 PM UTC+2 Mike Taylor wrote: >>> >>>> Hey Alex, >>>> >>>> Apologies for the delay. It would probably be good to make a new entry >>>> and request all the relevant review approvals (sorry for the extra work). >>>> >>>> Also, probably useful to drop a link in the TAG review to this Intent, >>>> so reviewers can eventually be aware of these changes. >>>> On 9/27/23 2:35 PM, Alex Turner wrote: >>>> >>>> I set this feature up as a "Web developer facing change to existing >>>> code", but I'm seeing that "New feature incubation" may have been more >>>> appropriate (although the guidance >>>> <https://www.chromium.org/blink/launching-features/#feature-types> is >>>> a bit uncertain). Unfortunately, that means chromestatus won't let me >>>> request any reviews other than API owners; would it make sense to create a >>>> new feature entry? (Note also that these changes have already gone through >>>> internal privacy and security reviews.) >>>> >>>> Thanks! >>>> Alex >>>> >>>> On Wed, Sep 27, 2023 at 12:02 PM Chris Harrelson <chris...@chromium.org> >>>> wrote: >>>> >>>>> Please also fill out the other chromestatus review categories for this >>>>> Intent, in particular for Privacy and Security, thanks. >>>>> >>>>> On Tue, Sep 26, 2023 at 11:14 PM Yoav Weiss <yoavwe...@chromium.org> >>>>> wrote: >>>>> >>>>>> >>>>>> >>>>>> On Mon, Sep 25, 2023 at 11:52 PM Alex Turner <ale...@chromium.org> >>>>>> wrote: >>>>>> >>>>>>> Contact emails ale...@chromium.org >>>>>>> >>>>>>> Specification >>>>>>> >>>>>>> - >>>>>>> >>>>>>> Null report fixes: >>>>>>> >>>>>>> https://github.com/patcg-individual-drafts/private-aggregation-api/pull/91 >>>>>>> - >>>>>>> >>>>>>> Debug mode eligibility changes: >>>>>>> >>>>>>> https://github.com/patcg-individual-drafts/private-aggregation-api/pull/90 >>>>>>> - >>>>>>> >>>>>>> Padding report payloads: >>>>>>> >>>>>>> https://github.com/patcg-individual-drafts/private-aggregation-api/pull/98, >>>>>>> https://github.com/WICG/attribution-reporting-api/pull/1030 >>>>>>> - >>>>>>> >>>>>>> Reducing delay: >>>>>>> >>>>>>> https://github.com/patcg-individual-drafts/private-aggregation-api/pull/103 >>>>>>> >>>>>>> >>>>>>> Summary >>>>>>> >>>>>>> We're planning a few bundled changes to Private Aggregation: >>>>>>> >>>>>>> - >>>>>>> >>>>>>> Null report fixes: Currently reports with no contributions are >>>>>>> inadvertently dropped. This change ensures that, when a context ID is >>>>>>> specified, a null report is sent even if budget is denied. >>>>>>> Separately, it >>>>>>> fixes a bug causing budget to always be denied for null reports. >>>>>>> - >>>>>>> >>>>>>> Debug mode eligibility changes: Currently, debug mode is always >>>>>>> available. This change only allows debug mode for callers that are >>>>>>> allowed >>>>>>> access to third-party cookies, silently dropping the debug mode >>>>>>> otherwise. >>>>>>> Note that this will allow debug mode to automatically sunset when >>>>>>> third-party cookies are deprecated. >>>>>>> - >>>>>>> >>>>>>> Padding report payloads: To avoid the payload size being >>>>>>> dependent on the number of contributions, we will pad it with 'null' >>>>>>> contributions to a fixed length. **Note**: this change will also >>>>>>> affect >>>>>>> Attribution Reporting’s aggregatable reports. >>>>>>> - >>>>>>> >>>>>>> Reducing delay: When a context ID is specified, we remove the >>>>>>> randomized 10-60 minute delay, which is superfluous as a report is >>>>>>> always >>>>>>> sent in this case. Instead, we just wait until the Shared Storage >>>>>>> operation >>>>>>> timeout. >>>>>>> >>>>>>> >>>>>>> Blink component Blink>PrivateAggregation >>>>>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EPrivateAggregation> >>>>>>> >>>>>>> TAG review https://github.com/w3ctag/design-reviews/issues/846 (We >>>>>>> have not requested a signal for these changes specifically.) >>>>>>> >>>>>>> TAG review status Pending >>>>>>> >>>>>>> Risks >>>>>>> >>>>>>> >>>>>>> Interoperability and Compatibility >>>>>>> >>>>>>> >>>>>>> - Null report fixes: Increases the number of reports sent to >>>>>>> reporting endpoints, reporting endpoints using plaintext debug >>>>>>> payloads >>>>>>> will need to handle the null report case. >>>>>>> >>>>>>> Do you know if current reporting endpoints are ready to handle this >>>>>> change? >>>>>> >>>>>>> >>>>>>> - Debug mode eligibility changes: Backwards incompatible for >>>>>>> callers using enableDebugMode() without third-party cookie >>>>>>> eligibility. >>>>>>> >>>>>>> Were callers already ready to have the enableDebugMode() call fail? >>>>>> Does it throw, or silently fails? >>>>>> >>>>>>> >>>>>>> - Padding report payloads: Compatible with existing aggregation >>>>>>> service versions. Reporting endpoints will see larger payloads and >>>>>>> null >>>>>>> contributions added to the plaintext debug payloads (if used). >>>>>>> - Reducing delay: Should not require any reporting endpoint >>>>>>> changes, reports will simply arrive earlier. >>>>>>> >>>>>>> >>>>>>> *Gecko*: No signal ( >>>>>>> https://github.com/mozilla/standards-positions/issues/805). We have >>>>>>> not requested a signal for these changes specifically. The Gecko >>>>>>> position >>>>>>> on Shared Storage (one of the ways Private Aggregation is exposed) is >>>>>>> negative. >>>>>>> >>>>>>> *WebKit*: No signal ( >>>>>>> https://github.com/WebKit/standards-positions/issues/189). We have >>>>>>> not requested a signal for these changes specifically >>>>>>> >>>>>>> *Web developers*: Positive for reducing delay >>>>>>> >>>>>>> *Other signals*: >>>>>>> >>>>>>> WebView application risks >>>>>>> >>>>>>> Does this intent deprecate or change behavior of existing APIs, such >>>>>>> that it has potentially high risk for Android WebView-based >>>>>>> applications? >>>>>>> >>>>>>> None >>>>>>> >>>>>>> >>>>>>> Debuggability >>>>>>> >>>>>>> No new debug capabilities beyond the existing internals page ( >>>>>>> chrome://private-aggregation-internals) and temporary debug mode. >>>>>>> >>>>>>> >>>>>>> Will this feature be supported on all six Blink platforms (Windows, >>>>>>> Mac, Linux, Chrome OS, Android, and Android WebView)? >>>>>>> >>>>>>> All but Webview >>>>>>> >>>>>>> >>>>>>> Is this feature fully tested by web-platform-tests >>>>>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>>>>>> ? WPTs will be added when features are enabled. >>>>>>> >>>>>>> Flag name on chrome://flags None >>>>>>> >>>>>>> Finch feature name Padding: >>>>>>> PrivacySandboxAggregationServiceReportPadding >>>>>>> All other features: PrivateAggregationApiBundledEnhancements >>>>>>> >>>>>>> Requires code in //chrome? Only for settings checks >>>>>>> >>>>>>> Tracking bug https://crbug.com/1481761 >>>>>>> >>>>>>> Launch bug https://launch.corp.google.com/launch/4272421 >>>>>>> >>>>>>> Estimated milestones >>>>>>> >>>>>>> We intend to ship in M119. >>>>>>> >>>>>>> Anticipated spec changes >>>>>>> None >>>>>>> >>>>>>> Link to entry on the Chrome Platform Status >>>>>>> https://chromestatus.com/feature/5205079858085888 >>>>>>> >>>>>>> Links to previous Intent discussions >>>>>>> >>>>>>> Previous I2S >>>>>>> <https://groups.google.com/a/chromium.org/g/blink-dev/c/8cKaLstq2QQ/m/Udrbb4ifDQAJ> >>>>>>> >>>>>>> This intent message was generated by Chrome Platform Status >>>>>>> <https://chromestatus.com/>. >>>>>>> -- >>>>>>> You received this message because you are subscribed to the Google >>>>>>> Groups "blink-dev" group. >>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>> send an email to blink-dev+unsubscr...@chromium.org. >>>>>>> To view this discussion on the web visit >>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAA%2BBiF%3DMBk5ra9sn9i4ajaNSd9aMFKE_9DpxE8pziGY6YXB9Mg%40mail.gmail.com >>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAA%2BBiF%3DMBk5ra9sn9i4ajaNSd9aMFKE_9DpxE8pziGY6YXB9Mg%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>>> . >>>>>>> >>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "blink-dev" group. >>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>> send an email to blink-dev+unsubscr...@chromium.org. >>>>>> To view this discussion on the web visit >>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfUzy0MKk6iD4MhPyeUwA-MESOo%2BGwsVX-GSb_MQUw2N8A%40mail.gmail.com >>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfUzy0MKk6iD4MhPyeUwA-MESOo%2BGwsVX-GSb_MQUw2N8A%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>> . >>>>>> >>>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "blink-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to blink-dev+unsubscr...@chromium.org. >>>> >>>> To view this discussion on the web visit >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAA%2BBiFnMoYuB98RHAHwm_f9VghuGZxc_VXMCMt1KXNbPoRvTkw%40mail.gmail.com >>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAA%2BBiFnMoYuB98RHAHwm_f9VghuGZxc_VXMCMt1KXNbPoRvTkw%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>>> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfVvRsH0F3Eya4g7ZU-gt-UcRauZ7YOjoWUHg1A_oTtDfQ%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfVvRsH0F3Eya4g7ZU-gt-UcRauZ7YOjoWUHg1A_oTtDfQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw-3%2BFG%3DFmdARrf-D%2B3r907GricF0Y2dKBTM7DyLvkzjvg%40mail.gmail.com.
