LGTM3 On Tue, Oct 17, 2023, 4:20 AM Yoav Weiss <yoavwe...@chromium.org> wrote:
> LGTM2 > > On Tue, Oct 17, 2023 at 12:05 AM Mike Taylor <miketa...@chromium.org> > wrote: > >> LGTM1 >> On 10/16/23 7:48 AM, Nan Lin wrote: >> >> Thanks Mike, please see the inline comment. >> >> On Mon, Oct 16, 2023 at 10:41 AM Mike Taylor <miketa...@chromium.org> >> wrote: >> >>> >>> Interoperability and Compatibility >>> >>> The change is backwards compatible, and allows developers to select the >>> deployment option for the aggregation service. By default, the AWS >>> coordinator will be used (the existing behavior), and the public keys will >>> be served on both old and new endpoints during the transition period. >>> >>> Can you say more about this transition period? Is this related to >>> "transitional debugging reports", or something else entirely? >>> >> >> This is about the transition period for releasing multiple cloud >> providers support. M119+ is going to fetch public keys from the new >> endpoint, whereas older versions still fetch from the old endpoint. >> Therefore to ensure not breaking older versions, the public keys will be >> served on both endpoints for some time after M119 release. >> >> OK - got it. At some future point you'll send an Intent to Deprecate & >> Remove sending public keys from the old endpoint. :) >> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/4616eb26-41c2-4186-b93a-9a8934097116%40chromium.org >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/4616eb26-41c2-4186-b93a-9a8934097116%40chromium.org?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfU4-w7D%2Bf4RDMv-WiJ7UBFKKysecyWv0Ukr0%2BZuwwd%3D_g%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfU4-w7D%2Bf4RDMv-WiJ7UBFKKysecyWv0Ukr0%2BZuwwd%3D_g%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw8uh1O1P13YR3mDBnrNVargQaosxVYogC8RAKg0uhztGQ%40mail.gmail.com.