LGTM3

On 10/25/23 11:25 AM, Chris Harrelson wrote:
LGTM2

On Wed, Oct 25, 2023 at 8:23 AM Yoav Weiss <yoavwe...@chromium.org> wrote:

    LGTM1

    On Wednesday, October 25, 2023 at 4:24:04 PM UTC+2 Clemens Backes
    wrote:

        There has not been an update on this ITS in 8 days. What's the
        expected timeline to get the LGTMs?


Last week was BlinkOn and we do most reviews in our weekly meeting on Wednesdays.


        As the M120 branch cut is around the corner, I'll go ahead and
        prepare the launch, given that this is a feature voted to
        phase 4 in the W3C WebAssembly Community Group and all other
        approvals are there.

        On Tue, Oct 17, 2023 at 8:09 PM Clemens Backes
        <cleme...@chromium.org> wrote:

            On Tue, Oct 17, 2023 at 7:42 PM Alex Russell
            <slightly...@chromium.org> wrote:

                It's unclear why the TAG is not being informed or
                consulted. This has deep architectural implications
                for DOM integration and I'd expect to see those
                explained and worked.


            As written in the ITS, a TAG review is not required as per
            https://v8.dev/docs/feature-launch-process#tag. The
            changes to the WebAssembly JS API are actually very
            minimal: Instead of one exported memory, you can now have
            multiple.

            I don't see any implication for anything DOM related (but
            I am also not entirely sure what you mean by "DOM
            integration", there is nothing like this planned in
            WebAssembly). Can you elaborate on that?


                On Tue, Oct 17, 2023, 10:08 AM Clemens Backes
                <cleme...@chromium.org> wrote:


                            Contact emails

                    cleme...@google.com


                            Explainer

                    We are ready for shipping the Multi-Memory
                    proposal for WebAssembly, which recently moved to
                    phase 4 according to the WebAssembly W3C process.


                            Specification

                    
https://github.com/WebAssembly/multi-memory/blob/main/proposals/multi-memory/Overview.md


                            Design docs

                    
https://github.com/WebAssembly/multi-memory/blob/main/proposals/multi-memory/Overview.md


                            Summary

                    Add support for more than one memory per
                    WebAssembly module as specified in the WebAssembly
                    Multi-Memory proposal:
                    
https://github.com/WebAssembly/multi-memory/blob/main/proposals/multi-memory/Overview.md


                            Blink component

                    Blink>JavaScript>WebAssembly
                    
<https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EJavaScript%3EWebAssembly>


                            Search tags

                    Wasm
                    <https://chromestatus.com/features#tags:Wasm>,
                    WebAssembly
                    <https://chromestatus.com/features#tags:WebAssembly>,
                    Multi-Memory
                    <https://chromestatus.com/features#tags:Multi-Memory>


                            TAG review


                            Not required as per:
                            https://v8.dev/docs/feature-launch-process.


                            TAG review status

                    Not applicable


                            Risks


                            Interoperability and Compatibility

                    None



                    /Gecko/: Positive

                    /WebKit/: Positive

                    /Web developers/: Strongly positive
                    (https://github.com/WebAssembly/proposals)

                    /Other signals/: This was voted to phase 4
                    (standardization) at the October 2023 WebAssembly
                    Community Group meeting. 38 of 43 votes were
                    "strongly for".


                            WebView application risks

                    Does this intent deprecate or change behavior of
                    existing APIs, such that it has potentially high
                    risk for Android WebView-based applications?

                    None



                            Debuggability

                    All memories are inspectable from DevTools, just
                    like the first memory.


                            Will this feature be supported on all six
                            Blink platforms (Windows, Mac, Linux,
                            Chrome OS, Android, and Android WebView)?

                    Yes


                            Is this feature fully tested by
                            web-platform-tests
                            
<https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>?

                    The WebAssembly proposal comes with all relevant
                    tests; we pass them.


                            Flag name on chrome://flags

                    enable-experimental-webassembly-features


                            Finch feature name

                    None


                            Non-finch justification

                    None


                            Requires code in //chrome?

                    False


                            Tracking bug

                    https://crbug.com/v8/13918


                            Estimated milestones

                    Shipping on desktop         120
                    DevTrial on desktop         117

                    Shipping on Android         120
                    DevTrial on Android         117

                    Shipping on WebView         120

                    Shipping on WebView         120
                    DevTrial on iOS     117




                            Anticipated spec changes

                    None.


                            Link to entry on the Chrome Platform Status

                    https://chromestatus.com/feature/5106389887746048



                    This intent message was generated by Chrome
                    Platform Status <https://chromestatus.com/>.

-- You received this message because you are
                    subscribed to the Google Groups "blink-dev" group.
                    To unsubscribe from this group and stop receiving
                    emails from it, send an email to
                    blink-dev+unsubscr...@chromium.org.
                    To view this discussion on the web visit
                    
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGO%3DqhA9xWgZXnGbC%2BYQ9XqJUmLwgxsyggKa9mGhsY%3DOXpzcsg%40mail.gmail.com
                    
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGO%3DqhA9xWgZXnGbC%2BYQ9XqJUmLwgxsyggKa9mGhsY%3DOXpzcsg%40mail.gmail.com?utm_medium=email&utm_source=footer>.





--
        Clemens Backes

        Software Engineer

        cleme...@google.com

        Google Germany GmbH

        Erika-Mann-Straße 33

        80636 München


        Geschäftsführer: Paul Manicle, Liana Sebastian

        Registergericht und -nummer: Hamburg, HRB 86891

        Sitz der Gesellschaft: Hamburg


        Diese E-Mail ist vertraulich. Falls sie diese
        fälschlicherweise erhalten haben sollten, leiten Sie diese
        bitte nicht an jemand anderes weiter, löschen Sie alle Kopien
        und Anhänge davon und lassen Sie mich bitte wissen, dass die
        E-Mail an die falsche Person gesendet wurde.


        This e-mail is confidential. If you received this
        communication by mistake, please don't forward it to anyone
        else, please erase all copies and attachments, and please let
        me know that it has gone to the wrong person.

-- You received this message because you are subscribed to the Google
    Groups "blink-dev" group.
    To unsubscribe from this group and stop receiving emails from it,
    send an email to blink-dev+unsubscr...@chromium.org.
    To view this discussion on the web visit
    
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/743b2bdb-0d91-411f-b2a6-6029e70ae342n%40chromium.org
    
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/743b2bdb-0d91-411f-b2a6-6029e70ae342n%40chromium.org?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw-L8O9ShKkqcM8S8fDTNKFT5D9S5V2ZtRN%3DXbSFXPCmwg%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw-L8O9ShKkqcM8S8fDTNKFT5D9S5V2ZtRN%3DXbSFXPCmwg%40mail.gmail.com?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/22e1d892-c182-4f2c-b5fb-bc122c728492%40chromium.org.

Reply via email to