Also, please request approval for the rest of the review gates (right now I only see Debuggability); you'll be blocked on getting the rest of the LGTMs until those are in progress.

On 10/30/23 9:42 AM, Mike Taylor wrote:

Thank you very much for the summary - I was trying to parse the thread on Friday and meant to ask follow-up questions. :)

LGTM1

On 10/29/23 11:09 PM, Domenic Denicola wrote:
Yes, I confirm that I have no more concerns at this point!

On Mon, Oct 30, 2023 at 10:04 AM TAMURA, Kent <tk...@chromium.org> wrote:

    API owners,

    I think this intent is ready for API owner approvals.

    * Domenic's concern was resolved by dropping '<rb>' from the
    scope of the intent.
    * We found we didn't need to update the HTML specification.
      ** It already asks "display:ruby" and "display:ruby-text" for
    <ruby> and <rt>
      ** I wrote "what we should do is to remove algorithms at
    https://html.spec.whatwg.org/C/#the-ruby-element:the-ruby-element-19";.
    But we don't need to remove them because they are not for
    rendering purposes.
    * WebKit is developing this feature. Firefox already shipped.

    On Thu, Oct 19, 2023 at 4:41 PM TAMURA, Kent <tk...@chromium.org>
    wrote:


                Contact emails

        tk...@chromium.org


                Explainer

        None


                Specification

        https://drafts.csswg.org/css-ruby-1/#ruby-display


                Summary

        New CSS displayproperty values, "ruby", "ruby-base", and
        "ruby-text", are added. The default display values of <ruby>,
        <rb> and <rt> are changed to them, and ruby layout respects
        these display values. Web authors can use any elements such
        as <div> to render ruby by setting the new display values.



                Blink component

        Blink>Layout>Ruby
        
<https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3ELayout%3ERuby>


                Search tags

        css <https://chromestatus.com/features#tags:css>, ruby
        <https://chromestatus.com/features#tags:ruby>


                TAG review

        None; Firefox already shipped this.


                TAG review status

        Not applicable


                Risks



                Interoperability and Compatibility

        This feature does not affect most <ruby> usages on existing
        pages. However, the rendering results may change if the
        `display` property value of <ruby> or <rt> is set to a
        non-default value because ruby rendering is triggered by the
        new `display` value, not the tag name.
        https://chromestatus.com/metrics/feature/timeline/popularity/3282
        At most 0.07% page views might be affected. However, <ruby>s
        in 9 of the top 10 sites have no <rt>, and their rendering
        won't be changed. The remaining 1 site will be broken, and
        it's same as Firefox's rendering result. We have a plan to
        show a console message about this incompatibility before
        enabling the feature.



        /Gecko/: Shipped/Shipping

        /WebKit/: Positive
        (https://github.com/WebKit/standards-positions/issues/232)

        /Web developers/: No signals

        /Other signals/:


                WebView application risks

        Does this intent deprecate or change behavior of existing
        APIs, such that it has potentially high risk for Android
        WebView-based applications?

        None



                Debuggability

        Rolling css_properties.json5 into devtools-frontend should be
        enough.



                Will this feature be supported on all six Blink
                platforms (Windows, Mac, Linux, Chrome OS, Android,
                and Android WebView)?

        Yes


                Is this feature fully tested by web-platform-tests
                
<https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>?

        Yes

        Some of https://wpt.fyi/results/css/css-ruby and
        https://wpt.fyi/results/css/css-display/parsing



                Flag name on chrome://flags

        None


                Finch feature name

        CssDisplayRuby


                Requires code in //chrome?

        False


                Tracking bug

        https://bugs.chromium.org/p/chromium/issues/detail?id=880802


                Estimated milestones

        Shipping on desktop     121

        Shipping on Android     121

        Shipping on WebView     121



                Anticipated spec changes

        Open questions about a feature may be a source of future web
        compat or interop issues. Please list open issues (e.g. links
        to known github issues in the project for the feature
        specification) whose resolution may introduce web
        compat/interop risk (e.g., changing to naming or structure of
        the API in a non-backward-compatible way).

        None


                Link to entry on the Chrome Platform Status

        https://chromestatus.com/feature/6416726833233920

        This intent message was generated by Chrome Platform Status
        <https://chromestatus.com/>.

-- TAMURA Kent
        Software Engineer, Google




-- TAMURA Kent
    Software Engineer, Google


-- You received this message because you are subscribed to the
    Google Groups "blink-dev" group.
    To unsubscribe from this group and stop receiving emails from it,
    send an email to blink-dev+unsubscr...@chromium.org.
    To view this discussion on the web visit
    
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqFTDZiUd980%3DOHb3OsQ8-279kXb9dSQu2JYprOX%2Bx8JGA%40mail.gmail.com
    
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqFTDZiUd980%3DOHb3OsQ8-279kXb9dSQu2JYprOX%2Bx8JGA%40mail.gmail.com?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM0wra-J66ckraNAKjs1Ps6wsv%2BQnPKPuBX4RUA4y3315W1Cmg%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM0wra-J66ckraNAKjs1Ps6wsv%2BQnPKPuBX4RUA4y3315W1Cmg%40mail.gmail.com?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/2c1635aa-15a7-44cd-8f8c-d93ad839877d%40chromium.org.

Reply via email to