Yeah looks pretty trivial, thanks for the improvement! LGTM1 On Wed, Nov 29, 2023 at 9:34 PM Jeremy Roman <jbro...@chromium.org> wrote:
> Contact emailsjbro...@chromium.org > > ExplainerNone > > Specification > https://urlpattern.spec.whatwg.org/#dom-urlpattern-hasregexpgroups > > Summary > > Allows easy inspection of whether a URLPattern uses one or more ECMAScript > regular expression groups, and therefore may not be suitable for use in > cases where an ECMAScript engine is not available (such as some upcoming > planned APIs). Strictly speaking this reflects back something developers > could know anyway from inspecting the pattern, but having easy access to > the UA's implementation of this check makes that more straightforward. > > > Blink componentBlink>URLPattern > <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EURLPattern> > > TAG reviewNone > > TAG review statusNot applicable > > Risks > > > Interoperability and Compatibility > > Interoperability risk is low. The feature is simple, has a small API > surface area, and is easy to implement. It could be polyfilled if other > browser vendors implemented URLPattern but not this feature, though that > outcome does not seem likely. > > > *Gecko*: No signal ( > https://mozilla.github.io/standards-positions/#urlpattern) This addition > is too trivial to request a separate position, but Mozilla is positive on > URLPattern generally. > > *WebKit*: No signal (https://webkit.org/standards-positions/#position-61) > This addition is too trivial to request a separate position, but WebKit is > positive on URLPattern generally. > > *Web developers*: No signals No significant signals, but this feature is > trivial > > *Other signals*: > > Ergonomics > > No significant concerns anticipated > > > Activation > > No; in fact this property is added specifically to make activation of > features which can only accept patterns with no regexp groups easier. > > > Security > > No security risks have been identified. > > > WebView application risks > > Does this intent deprecate or change behavior of existing APIs, such that > it has potentially high risk for Android WebView-based applications? > > None > > > Debuggability > > Standard developer tools (e.g., the JavaScript console) are likely to be > sufficient. If URL patterns become extremely popular one could imagine > tools particular to them, but those could be developed independently of > this ship decision. > > > Will this feature be supported on all six Blink platforms (Windows, Mac, > Linux, ChromeOS, Android, and Android WebView)?Yes > > Is this feature fully tested by web-platform-tests > <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> > ?Yes > > > https://wpt.fyi/results/urlpattern?label=master&label=experimental&aligned&q=urlpattern-hasregexpgroups > > > Flag name on chrome://flagsNone > > Finch feature nameURLPatternHasRegExpGroups > > Requires code in //chrome?False > > Tracking bughttps://bugs.chromium.org/p/chromium/issues/detail?id=1504650 > > Availability expectationDependent on implementation of URL Pattern API in > non-Chromium browsers. > > Estimated milestones > Shipping on desktop 122 > Shipping on Android 122 > Shipping on WebView 122 > If approvals arrive in time for 121 branch, I'll enable this in 121, but > I'm currently assuming not. > > Anticipated spec changes > > Open questions about a feature may be a source of future web compat or > interop issues. Please list open issues (e.g. links to known github issues > in the project for the feature specification) whose resolution may > introduce web compat/interop risk (e.g., changing to naming or structure of > the API in a non-backward-compatible way). > None > > Link to entry on the Chrome Platform Status > https://chromestatus.com/feature/4761338127843328 > > This intent message was generated by Chrome Platform Status > <https://chromestatus.com/>. > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACuR13eBnT2Ee55fE%3DcNw9v%3DoJ9SZ_H4%2B6RKZnUwfsW4W3e%3DGw%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACuR13eBnT2Ee55fE%3DcNw9v%3DoJ9SZ_H4%2B6RKZnUwfsW4W3e%3DGw%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY9LVvLvV6fe7H1kyJHKW1o0tN-CsYYBvez%2B9_JzRAmfjA%40mail.gmail.com.