LGTM3

At a higher level, it would be great for AV1/VP9 encode to end up in 
something like Interop. It makes me sad to be adding a vote here to enable 
a closed format when open ones are better.

On Wednesday, March 6, 2024 at 8:43:11 AM UTC-8 Philip Jägenstedt wrote:

> LGTM2
>
> I think that 
> https://wpt.fyi/results/mediacapture-record?label=master&label=experimental&aligned&q=mp4
>  
> are the relevant tests. LGTM assuming all of these tests pass with 
> MediaRecorderEnableMp4Muxer enabled. If that's not the case, is there some 
> functionality that won't be supported initially?
>
> On Wed, Mar 6, 2024 at 7:19 AM Yoav Weiss (@Shopify) <
> yoavwe...@chromium.org> wrote:
>
>> LGTM1
>>
>> On Tue, Mar 5, 2024 at 5:01 PM 'Michaela Merz' via blink-dev <
>> blink-dev@chromium.org> wrote:
>>
>>> Thank you for adding this. Finally we're going to be able to do 
>>> cross-browser video-recordings and playing. Can't wait to see it in 
>>> production.
>>>
>>> M.
>>>
>>>
>>> On Monday, March 4, 2024 at 3:50:13 PM UTC-7 sun...@microsoft.com wrote:
>>>
>>>> Mike, I've added feature detection and developer engagement on 
>>>> https://docs.google.com/document/d/1WV795DHY3Jf2p_htuAKZ9DXUefiGdQs29mCb8vRiHt8/edit?usp=sharing
>>>> .
>>>>
>>>> On Monday, March 4, 2024 at 2:13:11 PM UTC-8 Sunggook Chue wrote:
>>>>
>>>>> Yoav,
>>>>>
>>>>> Philipp's answer is correct, please let me know if you need any more 
>>>>> info to unblock.
>>>>>
>>>>> On Thursday, February 29, 2024 at 11:53:47 AM UTC-8 
>>>>> philipp...@googlemail.com wrote:
>>>>>
>>>>>> Yoav,
>>>>>>
>>>>>> in WebRTC land "we have a sample for that" (thanks to the one and 
>>>>>> only WebRTC devrel guy Sam Dutton, I think I stole this tagline from 
>>>>>> him)!
>>>>>>   https://webrtc.github.io/samples/src/content/getusermedia/record/
>>>>>> with recent changes to improve MP4 support.
>>>>>>
>>>>>> Discovery currently happens with isTypeSupported but it seems the WG 
>>>>>> just decided to deprecate that:
>>>>>>  
>>>>>> https://github.com/w3c/mediacapture-record/issues/202#issuecomment-1956065141
>>>>>> (not sure how I feel about that, I'd rather nuke MediaRecorder 
>>>>>> entirely in favor of WebCodecs + IndexedDB)
>>>>>>
>>>>>> Am Do., 29. Feb. 2024 um 09:13 Uhr schrieb Yoav Weiss (@Shopify) <
>>>>>> yoav...@chromium.org>:
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Thu, Feb 29, 2024 at 1:46 AM 'Sunggook Chue' via blink-dev <
>>>>>>> blin...@chromium.org> wrote:
>>>>>>>
>>>>>>>> Here is an explainer, summary only.
>>>>>>>>
>>>>>>>>
>>>>>>>> https://docs.google.com/document/d/1WV795DHY3Jf2p_htuAKZ9DXUefiGdQs29mCb8vRiHt8/edit?usp=sharing
>>>>>>>
>>>>>>>
>>>>>>> Thanks! That's very useful! :)
>>>>>>>
>>>>>>> What's the feature detection story? How can developers know which 
>>>>>>> formats are supported?
>>>>>>>  
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Wednesday, February 28, 2024 at 7:53:29 AM UTC-8 
>>>>>>>> yoav...@chromium.org wrote:
>>>>>>>>
>>>>>>>>> On Tue, Feb 27, 2024 at 1:45 AM Mike Taylor <mike...@chromium.org> 
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On 2/22/24 9:21 PM, 'Sunggook Chue' via blink-dev wrote:
>>>>>>>>>>
>>>>>>>>>> Contact emails 
>>>>>>>>>>
>>>>>>>>>> sun...@microsoft.com 
>>>>>>>>>>
>>>>>>>>>> dalec...@chromium.com (reviewer and mentor).
>>>>>>>>>>
>>>>>>>>>> Explainer 
>>>>>>>>>>
>>>>>>>>>> https://www.w3.org/TR/mediastream-recording/
>>>>>>>>>>
>>>>>>>>>> That's not an explainer..
>>>>>>>>> Could you maybe write a short (inline?) explainer that outlines 
>>>>>>>>> what it is that we want to ship, what it would help developers 
>>>>>>>>> achieve, how 
>>>>>>>>> we envision them using this feature, etc.?
>>>>>>>>>  
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Specification 
>>>>>>>>>>
>>>>>>>>>> https://www.w3.org/TR/mediastream-recording/
>>>>>>>>>>
>>>>>>>>>> Summary 
>>>>>>>>>>
>>>>>>>>>> Adds support for muxing audio/video into MP4 containers with 
>>>>>>>>>> MediaRecorder.
>>>>>>>>>>
>>>>>>>>>> Developers can record media format, container, with MP4 of H264 
>>>>>>>>>> video and AAC audio codecs in the MediaRecorder API.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Blink component 
>>>>>>>>>>
>>>>>>>>>> Blink::MediaRecording
>>>>>>>>>>
>>>>>>>>>> TAG review
>>>>>>>>>> TAG review status
>>>>>>>>>> Risks 
>>>>>>>>>>
>>>>>>>>>> No Additional risks on existing containers such as webm.
>>>>>>>>>>
>>>>>>>>>> Interoperability and Compatibility
>>>>>>>>>>
>>>>>>>>>> This is missing vendor and developer signals - can you add (or 
>>>>>>>>>> request) them please?
>>>>>>>>>>
>>>>>>>>>> Ergonomics 
>>>>>>>>>>
>>>>>>>>>> N/A
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Activation 
>>>>>>>>>>
>>>>>>>>>> Unchallenging to use.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Security 
>>>>>>>>>>
>>>>>>>>>> N/A
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> WebView Application Risks 
>>>>>>>>>>
>>>>>>>>>> N/A
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Debuggability 
>>>>>>>>>>
>>>>>>>>>> Developers can see the API failure on DevTools.
>>>>>>>>>>
>>>>>>>>>> Is this feature fully tested by web-platform-tests 
>>>>>>>>>> <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md>
>>>>>>>>>> ? 
>>>>>>>>>>
>>>>>>>>>> Yes
>>>>>>>>>>
>>>>>>>>>> Flag name 
>>>>>>>>>>
>>>>>>>>>> MediaRecorderEnableMp4Muxer
>>>>>>>>>>
>>>>>>>>>> Tracking bug 
>>>>>>>>>>
>>>>>>>>>> https://issues.chromium.org/issues/40127044
>>>>>>>>>>
>>>>>>>>>> Launch bug 
>>>>>>>>>>
>>>>>>>>>> https://issues.chromium.org/issues/40127044
>>>>>>>>>>
>>>>>>>>>> Sample links 
>>>>>>>>>>
>>>>>>>>>> https://webrtc.github.io/samples/src/content/getusermedia/record/
>>>>>>>>>>
>>>>>>>>>> Estimated milestones 
>>>>>>>>>>
>>>>>>>>>> Dev Trial on Desktop: 120
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Link to entry on the Chrome Platform Status 
>>>>>>>>>>
>>>>>>>>>> https://chromestatus.com/feature/5163469011943424
>>>>>>>>>>
>>>>>>>>>> Links to previous Intent discussions
>>>>>>>>>>
>>>>>>>>>> This intent message was generated by Chrome Platform Status 
>>>>>>>>>> <https://chromestatus.com/>.
>>>>>>>>>> -- 
>>>>>>>>>> You received this message because you are subscribed to the 
>>>>>>>>>> Google Groups "blink-dev" group.
>>>>>>>>>> To unsubscribe from this group and stop receiving emails from it, 
>>>>>>>>>> send an email to blink-dev+...@chromium.org.
>>>>>>>>>> To view this discussion on the web visit 
>>>>>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/1dd6d89b-34f4-4f18-b3e8-c1309d479530n%40chromium.org
>>>>>>>>>>  
>>>>>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/1dd6d89b-34f4-4f18-b3e8-c1309d479530n%40chromium.org?utm_medium=email&utm_source=footer>
>>>>>>>>>> .
>>>>>>>>>>
>>>>>>>>>> -- 
>>>>>>>>>> You received this message because you are subscribed to the 
>>>>>>>>>> Google Groups "blink-dev" group.
>>>>>>>>>> To unsubscribe from this group and stop receiving emails from it, 
>>>>>>>>>> send an email to blink-dev+...@chromium.org.
>>>>>>>>>>
>>>>>>>>> To view this discussion on the web visit 
>>>>>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/8119a014-24b2-487e-bbbd-324c1bf77081%40chromium.org
>>>>>>>>>>  
>>>>>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/8119a014-24b2-487e-bbbd-324c1bf77081%40chromium.org?utm_medium=email&utm_source=footer>
>>>>>>>>>> .
>>>>>>>>>>
>>>>>>>>> -- 
>>>>>>>> You received this message because you are subscribed to the Google 
>>>>>>>> Groups "blink-dev" group.
>>>>>>>> To unsubscribe from this group and stop receiving emails from it, 
>>>>>>>> send an email to blink-dev+...@chromium.org.
>>>>>>>> To view this discussion on the web visit 
>>>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/dc2463e3-ef73-46ff-888e-23c8a9e446b1n%40chromium.org
>>>>>>>>  
>>>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/dc2463e3-ef73-46ff-888e-23c8a9e446b1n%40chromium.org?utm_medium=email&utm_source=footer>
>>>>>>>> .
>>>>>>>>
>>>>>>> -- 
>>>>>>> You received this message because you are subscribed to the Google 
>>>>>>> Groups "blink-dev" group.
>>>>>>> To unsubscribe from this group and stop receiving emails from it, 
>>>>>>> send an email to blink-dev+...@chromium.org.
>>>>>>>
>>>>>> To view this discussion on the web visit 
>>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohSLqrnt2T_DvaBtdOJKi3x2jT%2BzU4BShATkzGFf%2BuUV4VA%40mail.gmail.com
>>>>>>>  
>>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohSLqrnt2T_DvaBtdOJKi3x2jT%2BzU4BShATkzGFf%2BuUV4VA%40mail.gmail.com?utm_medium=email&utm_source=footer>
>>>>>>> .
>>>>>>>
>>>>>> -- 
>>> You received this message because you are subscribed to the Google 
>>> Groups "blink-dev" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to blink-dev+unsubscr...@chromium.org.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/e82d495d-c4eb-421b-81c1-58113a89bcf5n%40chromium.org
>>>  
>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/e82d495d-c4eb-421b-81c1-58113a89bcf5n%40chromium.org?utm_medium=email&utm_source=footer>
>>> .
>>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "blink-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to blink-dev+unsubscr...@chromium.org.
>>
> To view this discussion on the web visit 
>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohSKakA0ijy7d-i%2B7iduD5ymE%2BPzB8Vd_UtUJR6O3fP5Mfg%40mail.gmail.com
>>  
>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohSKakA0ijy7d-i%2B7iduD5ymE%2BPzB8Vd_UtUJR6O3fP5Mfg%40mail.gmail.com?utm_medium=email&utm_source=footer>
>> .
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/413a7b0f-bcc3-4b89-b739-42c0e6f6067bn%40chromium.org.

Reply via email to