Am I correct in understanding that Gecko already mostly matches the behavior in the spec? I see that Firefox also fails most of the WPTs at https://wpt.fyi/results/css/cssom/getComputedStyle-pseudo-with-argument.html?label=master&label=experimental&aligned, but I guess that's because they haven't shipped ::highlight() pseudos.
How are you thinking about the compatibility risk? If we're making the parsing stricter in certain ways, presumably sites depending on that behavior could break. Omitting the ":" seems like it could be a particularly easy mistake to make. On the other hand the fact that WebKit (and I guess Gecko) already did it is an encouraging signal. -- Dan Clark On Friday, March 8, 2024 at 8:46:28 AM UTC-8 nrose...@chromium.org wrote: > Contact emailsnrose...@chromium.org > > ExplainerNone > > Specificationhttps://drafts.csswg.org/cssom/#dom-window-getcomputedstyle > > Summary > > The pseudo element argument in some APIs ( getComputedStyle(element, > pseudo) and new KeyframeEffect(target, keyframes, {pseudoElement}) is > currently parsed in a way that doesn't match the spec - e.g. it allows > pseudo-elements without ":", it doesn't parse whitespace correctly if there > is argument, and several other issues. There are many failing tests around > this. Recently webkit fixed this to more closely match the spec. Proposing > to modify the behavior to match the webkit implementation and the spec, > un-skipping most of the tests. Using a chromestatus entry for this as it's > a web-facing behavior change. > > > Blink componentBlink>CSS > <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3ECSS> > > TAG reviewNone > > TAG review statusNot applicable > > Risks > > > Interoperability and Compatibility > > None > > > *Gecko*: No signal > > *WebKit*: Shipped/Shipping ( > https://developer.apple.com/documentation/safari-technology-preview-release-notes/stp-release-190#Resolved-Issues) > > Safari fixed the compat issues in the latest STP. > > *Web developers*: No signals > > *Other signals*: > > Ergonomics > > Shouldn't be, this is fixing an existing feature. > > > Activation > > This should be mostly compatible with existing usage. > > > Security > > N/A > > > WebView application risks > > Does this intent deprecate or change behavior of existing APIs, such that > it has potentially high risk for Android WebView-based applications? > > N/A > > > Debuggability > > N/A > > > Will this feature be supported on all six Blink platforms (Windows, Mac, > Linux, ChromeOS, Android, and Android WebView)?Yes > > Is this feature fully tested by web-platform-tests > <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> > ?Yes > > This mainly captured in the following two tests, that should be mostly > unskipped after this change. > https://wpt.fyi/results/css/cssom/getComputedStyle-pseudo-with-argument.html > https://wpt.fyi/results/css/cssom/getComputedStyle-pseudo.html > > > Flag name on chrome://flagsCSSComputedStyleFullPseudoElementParser > > Finch feature nameCSSComputedStyleFullPseudoElementParser > > Requires code in //chrome?False > > Tracking bughttps://issues.chromium.org/issues/328470598 > > Adoption expectationIt's not a widely use feature, but mostly because > it's been incompatible across browsers for a long time. With > view-transitions making more use of pseudo-elements this will likely become > more important. > > Estimated milestones > Shipping on desktop 125 > Shipping on Android 125 > Shipping on WebView 125 > Shipping on WebView 125 > > Anticipated spec changes > > Open questions about a feature may be a source of future web compat or > interop issues. Please list open issues (e.g. links to known github issues > in the project for the feature specification) whose resolution may > introduce web compat/interop risk (e.g., changing to naming or structure of > the API in a non-backward-compatible way). > None, this is to match existing spec > > Link to entry on the Chrome Platform Status > https://chromestatus.com/feature/6230945893187584 > > This intent message was generated by Chrome Platform Status > <https://chromestatus.com/>. > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/ca79a5b7-65a1-4b46-9841-469d1d8165f7n%40chromium.org.
