We do have a runtime feature flag 'WritingSuggestions <https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/runtime_enabled_features.json5?q=writingsuggestions>'. We didn't think a Finch Trial was necessary, as the bulk of the changes were just adding the attribute and IDL functions <https://chromium-review.googlesource.com/c/chromium/src/+/5247315>. Since everything is implemented on the blink side, is a Finch feature flag still necessary? If it is, then I'll add that flag :)
On Wednesday, March 13, 2024 at 6:55:48 PM UTC-7 Domenic Denicola wrote: > > > On Thursday, March 14, 2024 at 2:08:28 AM UTC+9 Stephanie Zhang wrote: > > *Contact emails* > *sa...@microsoft.com*, *dan...@microsoft.com*, > *stephanie.zh...@microsoft.com* > > *Explainer* > > *https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/WritingSuggestions/explainer.md* > > <https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/WritingSuggestions/explainer.md> > > *Specification* > > *https://html.spec.whatwg.org/multipage/interaction.html#writing-suggestions* > <https://html.spec.whatwg.org/multipage/interaction.html> > > *Summary* > UAs are starting to provide writing suggestions to users as they type on > various editable fields across the web. While this is generally useful for > users, there are cases when developers may want to turn off UA-provided > writing assistance, such as extensions or sites that wish to provide > similar functionality on their own. To that end, developers need a solution > that would turn on/off UA-provided writing assistance. The new attribute > 'writingsuggestions' has values 'true'/'false' that would allow developers > to turn on/off browser-provided writing suggestions. The attribute's state > for an element can also be inherited from ancestor elements, thereby > allowing developers to control this functionality at a per-element or > per-document/sub-document scale. > > > *Blink component* > *Blink>Editing* > <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EEditing> > > *TAG review* > *https://github.com/w3ctag/design-reviews/issues/924* > <https://github.com/w3ctag/design-reviews/issues/924> > > *TAG review status* > Issues addressed > > *Risks* > > > *Interoperability and Compatibility* > None > > > *Gecko*: No signal ( > *https://github.com/mozilla/standards-positions/issues/855* > <https://github.com/mozilla/standards-positions/issues/855>) > > *WebKit*: In development ( > *https://github.com/WebKit/standards-positions/issues/308* > <https://github.com/WebKit/standards-positions/issues/308>) WebKit > Implementation PR: *https://github.com/WebKit/WebKit/pull/24051* > <https://github.com/WebKit/WebKit/pull/24051> > > *Web developers*: No signals > > *Other signals*: > > *Ergonomics* > None > > > *Activation* > None > > > *Security* > None > > > *WebView application risks* > *Does this intent deprecate or change behavior of existing APIs, such that > it has potentially high risk for Android WebView-based applications?* > None > > > *Debuggability* > None > > > *Will this feature be supported on all six Blink platforms (Windows, Mac, > Linux, ChromeOS, Android, and Android WebView)?* > Yes > Attribute is available on all platforms. > > > *Is this feature fully tested by* *web-platform-tests* > <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> > *?* > Yes > > *https://wpt.fyi/results/html/editing/editing-0/writing-suggestions/writingsuggestions.html?label=master&label=experimental&aligned* > > <https://wpt.fyi/results/html/editing/editing-0/writing-suggestions/writingsuggestions.html?label=master&label=experimental&aligned> > > > *Flag name on chrome://flags* > None > > *Finch feature name* > None > > > Per the flag guidelines > <https://chromium.googlesource.com/chromium/src/+/main/docs/flag_guarding_guidelines.md>, > > all new features are required to be placed behind a Finch feature flag > (i.e. base::Feature flag). Can you ensure this is done and update the > Chrome Status entry? > > > > *Non-finch justification* > No finch trial needed. > > > *Requires code in //chrome?* > False > > *Estimated milestones* > Shipping on desktop 124 > > Shipping on Android 124 > > Shipping on WebView 124 > > > > *Anticipated spec changes* > *Open questions about a feature may be a source of future web compat or > interop issues. Please list open issues (e.g. links to known github issues > in the project for the feature specification) whose resolution may > introduce web compat/interop risk (e.g., changing to naming or structure of > the API in a non-backward-compatible way).* > None > > *Link to entry on the Chrome Platform Status* > *https://chromestatus.com/feature/5153375153029120* > <https://chromestatus.com/feature/5153375153029120> > > *Links to previous Intent discussions* > Intent to prototype: > *https://groups.google.com/a/chromium.org/g/blink-dev/c/rHyRCx-hJhE* > <https://groups.google.com/a/chromium.org/g/blink-dev/c/rHyRCx-hJhE> > This intent message was generated by *Chrome Platform Status* > <https://chromestatus.com/>. > > > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/8d6a0046-1a9b-44a4-9403-51067ca119fen%40chromium.org.
