Pro-tip for API Owners who want to get their L-G-T-M's detected via email: start your reply with the magic word.
ChromeStatus only looks for LGTMs in the first non-blank line of your message, which could be a whole paragraph since people usually don't break lines themselves in emails. The reason for that is to avoid detecting one that is mentioned as part of a nuanced discussion, e.g., "You are missing these things... <br> ... <br>.... After you address them, I will be happy to LGTM." Meta-example: I could use LTGM in this point in the discussion without accidentally approving the request myself because this is not the first non-blank line. Also, since we are on the topic, ChromeStatus will not treat the phrases "not LGTM", "almost LGTM", "need LGTM", "want LGTM", or "missing LGTM" as an approval. But, if you use some other negative term, it might slip past that rule and be counted as approval. If that ever happens, you can always change your vote on chromestatus.com. Thanks, jason! On Wednesday, May 29, 2024 at 10:31:33 AM UTC-7 chan...@chromium.org wrote: Thanks for the LGTMs. By the way, the ChromeStatus page is still gray due to one missing approval. Could you check it and add your approval if you forgot it? Thanks, jason! -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/21f5ffb1-05ee-4d05-a3d9-3efe459d1e50n%40chromium.org.
