On Wed, Jun 5, 2024 at 5:49 PM Philip Jägenstedt <foo...@chromium.org> wrote:
> Hi Jiaming, > > This feature has previously come across my radar as it appears in MDN to > be implemented by both Firefox and Safari already: > > https://developer.mozilla.org/en-US/docs/Web/API/MediaSession/setActionHandler#browser_compatibility > > Is this accurate, is it in fact already implemented in Firefox and Safari? > > >From what I can see in https://bugs.webkit.org/show_bug.cgi?id=217797, WebKit implements SkipAd. Firefox also implements it according to https://bugzilla.mozilla.org/show_bug.cgi?id=1582569 Best regards, > Philip > > On Tue, Jun 4, 2024 at 10:33 PM 'Jiaming Cheng' via blink-dev < > blink-dev@chromium.org> wrote: > >> Hey Alex, >> >> Thanks for your feedback! I have talked with the previous owner >> (fbeaufort@) of this feature. Please see our answers below inline. >> >> - Are you investigating a generic action button type, the way we've >> added one for Notifications >> <https://developer.mozilla.org/en-US/docs/Web/API/notification/actions> >> ? >> - If you have investigated that, would this feature be better as a >> custom user/developer action? >> >> The skipAd media session action is not related to Notifications at all. >> It is a common media action like play, pause, next, previous, skip, etc. >> See historical PR that was approved by Media Session folks: >> https://github.com/w3c/mediasession/pull/203#issuecomment-432529816 >> >> >> - Have you asked the TAG about consistency w/ Notification Actions >> for this design? and, most importantly... >> >> The TAG folks have not started talking about this yet at >> https://github.com/w3ctag/design-reviews/issues/957 >> >> >> - Has there been developer feedback that supports this, either from >> OT or from community feedback more generally? >> >> Our team (ChromeOS) and the Youtube team are recently planning to >> integrate this feature in our upcoming project, so that's why we are now >> proposing to enable it. >> >> >> Let me know if you have any other questions :] >> >> >> Best, >> Jiaming >> >> On Wed, May 29, 2024 at 9:04 AM Alex Russell <slightly...@chromium.org> >> wrote: >> >>> Hey folks, >>> >>> A few questions from today's API OWNERS: >>> >>> >>> - Are you investigating a generic action button type, the way we've >>> added one for Notifications >>> <https://developer.mozilla.org/en-US/docs/Web/API/notification/actions> >>> ? >>> - If you have investigated that, would this feature be better as a >>> custom user/developer action? >>> - Have you asked the TAG about consistency w/ Notification Actions >>> for this design? and, most importantly... >>> - Has there been developer feedback that supports this, either from >>> OT or from community feedback more generally? >>> >>> Best, >>> >>> Alex >>> >>> On Thursday, May 23, 2024 at 1:28:03 PM UTC-7 Jiaming Cheng wrote: >>> >>>> Updated the subject of this thread. >>>> >>>> Key links: >>>> ChromeStatus: >>>> https://chromestatus.com/feature/4749278882824192?gate=4775000754618368 >>>> TAG: https://github.com/w3ctag/design-reviews/issues/957 >>>> Mozilla: https://github.com/mozilla/standards-positions/issues/1026 >>>> Webkit: https://github.com/WebKit/standards-positions/issues/350 >>>> >>>> On Thu, May 23, 2024 at 1:13 PM Chris Harrelson <chris...@chromium.org> >>>> wrote: >>>> >>>>> >>>>> >>>>> On Thu, May 23, 2024 at 1:10 PM Jiaming Cheng <jiami...@google.com> >>>>> wrote: >>>>> >>>>>> Hi Chris, >>>>>> >>>>>> We are looking to ship this feature to Stable. We have reused an >>>>>> existing chromestatus ( >>>>>> https://chromestatus.com/feature/4749278882824192?gate=4775000754618368) >>>>>> and updated almost every section, including filling all the "Prepare to >>>>>> Ship" section. This email was automatically generated by the "API Owners >>>>>> Review" step in that section after each individual section was approved. >>>>>> I >>>>>> have quoted the previous email thread in this email for additional >>>>>> context. >>>>>> >>>>> >>>>> Ok. Please then start a new thread (or reply with a change of subject) >>>>> to "Intent to ship: Skip Ad in Picture-in-Picture window" >>>>> >>>>> >>>>>> >>>>>> If you have any further questions or concerns, please let us know. >>>>>> >>>>>> Thanks, >>>>>> Jiaming >>>>>> >>>>>> On Thu, May 23, 2024 at 12:29 PM Chris Harrelson < >>>>>> chris...@chromium.org> wrote: >>>>>> >>>>>>> Are you looking to ship this feature or just experiment? If you're >>>>>>> looking to ship please send a new email with a corrected subject and >>>>>>> contents, and request API owners review on chromestatus.com. >>>>>>> >>>>>>> On Wed, May 22, 2024 at 7:43 AM Chris Harrelson < >>>>>>> chris...@chromium.org> wrote: >>>>>>> >>>>>>>> I went ahead and marked the review as started on chromestatus.com. >>>>>>>> >>>>>>>> On Wed, May 22, 2024 at 7:36 AM Daniel Bratell <brat...@sarasas.se> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Unfortunately it doesn't show up in the API Owner UI/ToDo list and >>>>>>>>> I can't directly see how to make it appear. jrobbins, is there >>>>>>>>> anything >>>>>>>>> strange with this one? It is very old so it might be different from >>>>>>>>> anything done the last couple of years. >>>>>>>>> >>>>>>>>> /Daniel >>>>>>>>> On 2024-05-17 22:39, 'Jiaming Cheng' via blink-dev wrote: >>>>>>>>> >>>>>>>>> Hi team, >>>>>>>>> >>>>>>>>> This feature was initially proposed and implemented 4 years ago >>>>>>>>> but remained disabled due to a lack of practical use cases. Given >>>>>>>>> our team's (chromeOS UI team) plan to use this SkipAd action in our >>>>>>>>> upcoming project, we are now resending this intent email for LGTMs. >>>>>>>>> Please >>>>>>>>> let me know if you have any questions :] >>>>>>>>> >>>>>>>>> TAG: https://github.com/w3ctag/design-reviews/issues/957 >>>>>>>>> Mozilla: >>>>>>>>> https://github.com/mozilla/standards-positions/issues/1026 >>>>>>>>> Webkit: https://github.com/WebKit/standards-positions/issues/350 >>>>>>>>> >>>>>>>>> Below are the auto generated intent content: >>>>>>>>> Contact emailsfbeauf...@chromium.org, mlamo...@chromium.org, >>>>>>>>> jiami...@chromium.org >>>>>>>>> >>>>>>>>> ExplainerNone >>>>>>>>> >>>>>>>>> Specification >>>>>>>>> https://wicg.github.io/picture-in-picture/#media-session >>>>>>>>> >>>>>>>>> Design docs >>>>>>>>> >>>>>>>>> https://developers.google.com/web/updates/2019/02/chrome-73-media-updates#skipad >>>>>>>>> https://github.com/WICG/mediasession/pull/203 >>>>>>>>> >>>>>>>>> Summary >>>>>>>>> >>>>>>>>> Support the SkipAd media session action. This skipad action allows >>>>>>>>> Chrome to show a button in the system media controls or in the PiP >>>>>>>>> window. >>>>>>>>> >>>>>>>>> >>>>>>>>> Blink componentBlink>Media>PictureInPicture >>>>>>>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EMedia%3EPictureInPicture> >>>>>>>>> >>>>>>>>> TAG review: >>>>>>>>> https://github.com/w3ctag/design-reviews/issues/957 >>>>>>>>> >>>>>>>>> TAG review statusPending >>>>>>>>> >>>>>>>>> Chromium Trial NameSkipAd >>>>>>>>> >>>>>>>>> Link to origin trial feedback summary >>>>>>>>> https://github.com/WICG/picture-in-picture/issues >>>>>>>>> >>>>>>>>> Origin Trial documentation link >>>>>>>>> https://wicg.github.io/mediasession/#dom-mediasessionaction-skipad >>>>>>>>> >>>>>>>>> Risks >>>>>>>>> >>>>>>>>> >>>>>>>>> Interoperability and Compatibility >>>>>>>>> >>>>>>>>> None >>>>>>>>> >>>>>>>>> >>>>>>>>> *Gecko*: >>>>>>>>> https://github.com/mozilla/standards-positions/issues/1026 >>>>>>>>> >>>>>>>>> *WebKit*: Positive ( >>>>>>>>> https://github.com/WICG/mediasession/pull/203#issuecomment-432529816 >>>>>>>>> ) >>>>>>>>> And a new one created: >>>>>>>>> https://github.com/WebKit/standards-positions/issues/350 >>>>>>>>> >>>>>>>>> *Web developers*: Positive >>>>>>>>> >>>>>>>>> *Other signals*: >>>>>>>>> >>>>>>>>> WebView application risks >>>>>>>>> >>>>>>>>> Does this intent deprecate or change behavior of existing APIs, >>>>>>>>> such that it has potentially high risk for Android WebView-based >>>>>>>>> applications? >>>>>>>>> >>>>>>>>> None >>>>>>>>> >>>>>>>>> >>>>>>>>> Debuggability >>>>>>>>> >>>>>>>>> None >>>>>>>>> >>>>>>>>> >>>>>>>>> Will this feature be supported on all six Blink platforms >>>>>>>>> (Windows, Mac, Linux, ChromeOS, Android, and Android WebView)?No >>>>>>>>> >>>>>>>>> Is this feature fully tested by web-platform-tests >>>>>>>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>>>>>>>> ?No >>>>>>>>> >>>>>>>>> Flag name on chrome://flagsNone >>>>>>>>> >>>>>>>>> Finch feature nameNone >>>>>>>>> >>>>>>>>> Non-finch justificationNone >>>>>>>>> >>>>>>>>> Requires code in //chrome?False >>>>>>>>> >>>>>>>>> Tracking bug >>>>>>>>> https://bugs.chromium.org/p/chromium/issues/detail?id=910436 >>>>>>>>> >>>>>>>>> Sample links >>>>>>>>> >>>>>>>>> https://googlechrome.github.io/samples/picture-in-picture/skip-ad.html >>>>>>>>> >>>>>>>>> Estimated milestones >>>>>>>>> Shipping on desktop >>>>>>>>> 127 >>>>>>>>> Origin trial desktop first >>>>>>>>> 73 >>>>>>>>> Origin trial desktop last >>>>>>>>> 74 >>>>>>>>> >>>>>>>>> Anticipated spec changes >>>>>>>>> >>>>>>>>> Open questions about a feature may be a source of future web >>>>>>>>> compat or interop issues. Please list open issues (e.g. links to known >>>>>>>>> github issues in the project for the feature specification) whose >>>>>>>>> resolution may introduce web compat/interop risk (e.g., changing to >>>>>>>>> naming >>>>>>>>> or structure of the API in a non-backward-compatible way). >>>>>>>>> None >>>>>>>>> >>>>>>>>> Link to entry on the Chrome Platform Status >>>>>>>>> https://chromestatus.com/feature/4749278882824192?gate=4775000754618368 >>>>>>>>> >>>>>>>>> Links to previous Intent discussionsIntent to Experiment: >>>>>>>>> https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/l6sW0G4jzhE >>>>>>>>> On Sunday, February 10, 2019 at 2:08:11 AM UTC-8 Yoav Weiss wrote: >>>>>>>>> >>>>>>>>>> Still LGTM >>>>>>>>>> >>>>>>>>>> On Thu, Feb 7, 2019 at 9:51 PM François Beaufort < >>>>>>>>>> beaufort...@gmail.com> wrote: >>>>>>>>>> >>>>>>>>>>> After more thoughts, we'd like to extend the original trial to >>>>>>>>>>> expire when M75 Stable is cut, instead of M74 Stable cut. >>>>>>>>>>> Note that the origin trial didn't start yet. >>>>>>>>>>> >>>>>>>>>>> On Thursday, February 7, 2019 at 2:24:52 PM UTC+1, Yoav Weiss >>>>>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>> LGTM to experiment >>>>>>>>>>>> >>>>>>>>>>>> On Mon, Feb 4, 2019 at 8:40 PM François Beaufort < >>>>>>>>>>>> beaufort...@gmail.com> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Contact emails >>>>>>>>>>>>> >>>>>>>>>>>>> fbea...@chromium.org, mlam...@chromium.org >>>>>>>>>>>>> >>>>>>>>>>>>> Explainer >>>>>>>>>>>>> >>>>>>>>>>>>> https://github.com/WICG/mediasession/pull/203 >>>>>>>>>>>>> >>>>>>>>>>>>> Design doc/Spec >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> https://wicg.github.io/mediasession/#dom-mediasessionaction-skipad >>>>>>>>>>>>> >>>>>>>>>>>>> Summary >>>>>>>>>>>>> >>>>>>>>>>>>> Show a “Skip Ad” button in Picture-in-Picture window that >>>>>>>>>>>>> websites can be notified when user interact with. >>>>>>>>>>>>> >>>>>>>>>>>>> Motivation >>>>>>>>>>>>> >>>>>>>>>>>>> Video advertisement model usually consist of pre-roll ads. >>>>>>>>>>>>> Content providers often provide the ability to skip the ad after >>>>>>>>>>>>> a few >>>>>>>>>>>>> seconds. The Picture-in-Picture window being not interactive, >>>>>>>>>>>>> users >>>>>>>>>>>>> watching a video in Picture-in-Picture can’t do this today. This >>>>>>>>>>>>> feature >>>>>>>>>>>>> will allow websites to offer this experience also in the >>>>>>>>>>>>> Picture-in-Picture >>>>>>>>>>>>> window. This is one of the most common feature requests around >>>>>>>>>>>>> Picture-in-Picture. >>>>>>>>>>>>> >>>>>>>>>>>>> Risks >>>>>>>>>>>>> >>>>>>>>>>>>> Interoperability and Compatibility >>>>>>>>>>>>> >>>>>>>>>>>>> Safari has shipped a vendor-prefixed API for >>>>>>>>>>>>> Picture-in-Picture and we’re working >>>>>>>>>>>>> <https://github.com/WICG/picture-in-picture/pull/69#issuecomment-405394446> >>>>>>>>>>>>> with them on the integration of the Media Session in >>>>>>>>>>>>> Picture-in-Picture. >>>>>>>>>>>>> >>>>>>>>>>>>> Edge: Public support >>>>>>>>>>>>> <https://github.com/WICG/picture-in-picture/pull/69#issuecomment-432516966> >>>>>>>>>>>>> >>>>>>>>>>>>> Firefox: No signals >>>>>>>>>>>>> >>>>>>>>>>>>> Safari: Public support >>>>>>>>>>>>> <https://github.com/WICG/mediasession/pull/203#issuecomment-432529816> >>>>>>>>>>>>> >>>>>>>>>>>>> Web / Framework developers: Positive >>>>>>>>>>>>> >>>>>>>>>>>>> Activation >>>>>>>>>>>>> >>>>>>>>>>>>> Web developers will be able to simply set/unset a media >>>>>>>>>>>>> session action handler for “Skip Ad” to control the visibility of >>>>>>>>>>>>> the >>>>>>>>>>>>> button in the Picture-in-Picture window. Developer >>>>>>>>>>>>> documentation will cover this feature as we did before at >>>>>>>>>>>>> https://developers.google.com/web/updates/2017/02/media-session >>>>>>>>>>>>> . >>>>>>>>>>>>> >>>>>>>>>>>>> Goals for experimentation >>>>>>>>>>>>> >>>>>>>>>>>>> - >>>>>>>>>>>>> >>>>>>>>>>>>> Gather feedback about the shape of the API >>>>>>>>>>>>> - >>>>>>>>>>>>> >>>>>>>>>>>>> Validate that the API provides sufficient functionality >>>>>>>>>>>>> for content providers using it to deliver user value. This >>>>>>>>>>>>> will be measured >>>>>>>>>>>>> by: >>>>>>>>>>>>> - >>>>>>>>>>>>> >>>>>>>>>>>>> content providers that join the origin trial and choose >>>>>>>>>>>>> to share their feedback >>>>>>>>>>>>> - >>>>>>>>>>>>> >>>>>>>>>>>>> watch time that occurs in Picture in Picture mode >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Experimental timeline >>>>>>>>>>>>> >>>>>>>>>>>>> - >>>>>>>>>>>>> >>>>>>>>>>>>> Starts around M73 Beta release, 2019-02-07 >>>>>>>>>>>>> - >>>>>>>>>>>>> >>>>>>>>>>>>> Expires when M74 Stable is cut, around 2019-04-16 >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Any risks when the experiment finishes? >>>>>>>>>>>>> >>>>>>>>>>>>> No significant risks - content providers will feature detect >>>>>>>>>>>>> and fall back to their current behavior when we disable the >>>>>>>>>>>>> origin trial. >>>>>>>>>>>>> >>>>>>>>>>>>> Ongoing technical constraints >>>>>>>>>>>>> >>>>>>>>>>>>> None >>>>>>>>>>>>> >>>>>>>>>>>>> Will this feature be supported on all six Blink platforms >>>>>>>>>>>>> (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)? >>>>>>>>>>>>> >>>>>>>>>>>>> The feature will be supported on all platforms that currently >>>>>>>>>>>>> support the Picture-in-Picture API. >>>>>>>>>>>>> >>>>>>>>>>>>> Link to entry on the feature dashboard >>>>>>>>>>>>> <https://www.chromestatus.com/> >>>>>>>>>>>>> >>>>>>>>>>>>> https://www.chromestatus.com/feature/4749278882824192 >>>>>>>>>>>>> >>>>>>>>>>>>> -- >>>>>>>>>>>>> You received this message because you are subscribed to the >>>>>>>>>>>>> Google Groups "blink-dev" group. >>>>>>>>>>>>> To unsubscribe from this group and stop receiving emails from >>>>>>>>>>>>> it, send an email to blink-dev+...@chromium.org. >>>>>>>>>>>>> To view this discussion on the web visit >>>>>>>>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/b8a46914-72f6-4bc2-a5ba-d10db89ce6f0%40chromium.org >>>>>>>>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/b8a46914-72f6-4bc2-a5ba-d10db89ce6f0%40chromium.org?utm_medium=email&utm_source=footer> >>>>>>>>>>>>> . >>>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>> You received this message because you are subscribed to the >>>>>>>>>>> Google Groups "blink-dev" group. >>>>>>>>>>> To unsubscribe from this group and stop receiving emails from >>>>>>>>>>> it, send an email to blink-dev+...@chromium.org. >>>>>>>>>>> >>>>>>>>>> To view this discussion on the web visit >>>>>>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/466b0823-d33b-4d3b-a825-53955ca2a5ef%40chromium.org >>>>>>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/466b0823-d33b-4d3b-a825-53955ca2a5ef%40chromium.org?utm_medium=email&utm_source=footer> >>>>>>>>>>> . >>>>>>>>>>> >>>>>>>>>> -- >>>>>>>>> You received this message because you are subscribed to the Google >>>>>>>>> Groups "blink-dev" group. >>>>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>>>> send an email to blink-dev+unsubscr...@chromium.org. >>>>>>>>> To view this discussion on the web visit >>>>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/ad00b08f-9135-4d9c-add6-92d84bc14d4bn%40chromium.org >>>>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/ad00b08f-9135-4d9c-add6-92d84bc14d4bn%40chromium.org?utm_medium=email&utm_source=footer> >>>>>>>>> . >>>>>>>>> >>>>>>>>> -- >>>>>>>>> You received this message because you are subscribed to the Google >>>>>>>>> Groups "blink-dev" group. >>>>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>>>> send an email to blink-dev+unsubscr...@chromium.org. >>>>>>>>> To view this discussion on the web visit >>>>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/8b8baa0d-001b-48c3-bc21-b11240d449c9%40sarasas.se >>>>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/8b8baa0d-001b-48c3-bc21-b11240d449c9%40sarasas.se?utm_medium=email&utm_source=footer> >>>>>>>>> . >>>>>>>>> >>>>>>>> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABE8buQAXPXn_%2BCwDpz2ztB6tAum75RYVigYRP285p%3D0vVM%3DkQ%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABE8buQAXPXn_%2BCwDpz2ztB6tAum75RYVigYRP285p%3D0vVM%3DkQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPpwU5J0PUsyfohWoyk8N1F3K%3DGJvBLKCAOO%3DggtHSgfz68hig%40mail.gmail.com.
