On Wed, Mar 12, 2025 at 3:12 PM Mike Taylor <miketa...@chromium.org> wrote:
> On 3/12/25 5:38 PM, Frank Tang (譚永鋒) wrote: > > > > On Wed, Mar 12, 2025 at 8:19 AM Chris Harrelson <chris...@chromium.org> > wrote: > >> >> >> On Wed, Mar 5, 2025 at 10:39 AM 'Frank Tang (譚永鋒)' via blink-dev < >> blink-dev@chromium.org> wrote: >> >>> >>> >>> On Wed, Mar 5, 2025 at 6:02 AM Daniel Bratell <bratel...@gmail.com> >>> wrote: >>> >>>> Looks like the use counter LocaleInfoObsoleteGetters is at 0.033% which >>>> is a bit high. >>>> >>> Dear Daniel: >>> >>> From your point of view, could you please define what number would >>> be considered as not "high" or "low enough" ? >>> >> >> We don't have a hard and fast rule, but in this case it's "high enough" >> that we would like a bit more info to estimate risk. >> > > If there are no hard and fast rules, then how do we determine 0.033% is a > bit high? but not low enough? gut feeling? > > Experience breaking things. See > https://docs.google.com/document/d/1RC-pBBvsazYfCNNUSkPqAVpSpNJ96U8trhNkfV0v9fk/edit?tab=t.0#heading=h.83o2xr8ayal6. > > > > > >> >>> >>> >>>> >>> I can't see LocaleInfoFunctions at all so does that mean that it has >>>> never been triggered? >>>> >>> No, we didn't hook up that to the same UI. All other intl features were >>> hook up with this UI and while I added the CL >>> https://chromium-review.googlesource.com/c/chromium/src/+/6020626/ So >>> syg@ said I should not use blink_feature but webdx_feature due to >>> "jstenback's >>> email about WebDX features" >>> >>> So I hooked up the counter of both kLocaleInfoObsoletedGetters >>> and kLocaleInfoFunctions to that >>> but we later on find there are no easy way to access that info from >>> public UI yet. So in >>> https://chromium-review.googlesource.com/c/chromium/src/+/6089243 I >>> change LocaleInfoObsoleteGetters back to blink_feature >>> >>> I am not sure how to access the query to check webdx_feature. If anyone >>> know how to query that, we can see from that. >>> >> >> Your use counter is here: >> https://chromestatus.com/metrics/feature/timeline/popularity/5232 >> > > That one is for LocaleInfoObsoleteGetters, which is blink_feature that we > know how to see the counter > What we do not know how to access is kLocaleInfoFunctions, which is > webdx_feature that we do not know how to access the counter. > > Please reach out to pastithas@ or kadirtopal@ for help on that. > Unfortunately we don't yet expose these use counters in ChromeStatus, but we're working on it. In the meantime internal UMA data <https://uma.googleplex.com/p/chrome/timeline_v2?sid=f68dc5965348456a1cfb7dae5fa891d8> should help make progress here. Thanks, Panos -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAJ8Nf23YhpqRu91ShWcrQLgeoOrjC5KsDnhexLVK7S-sGM7tfA%40mail.gmail.com.
