LGTM2, also conditional on tests being added. Thanks for getting position requests filed (https://github.com/mozilla/standards-positions/issues/1295, https://github.com/WebKit/standards-positions/issues/547). -- Dan
On Wednesday, September 3, 2025 at 7:16:05 AM UTC-7 [email protected] wrote: > LGTM1, conditional on the testing situation getting sorted to Dan and > Domenic's satisfaction. > > Best, > > Alex > > On Wednesday, September 3, 2025 at 10:29:22 AM UTC+1 Noam Rosenthal wrote: > >> On Wed, Sep 3, 2025 at 1:59 AM Domenic Denicola <[email protected]> >> wrote: >> >>> >>> >>> On Wed, Sep 3, 2025 at 9:04 AM 'Daniel Clark' via blink-dev < >>> [email protected]> wrote: >>> >>>> > I believe in WPT we can't have an a.html top-frame navigate to b.html >>>> and check things there. I was not able to find an example in >>>> wpt/navigation-api/. Did I miss anything? >>>> >>>> >>>> >>>> I think it’s correct that we can’t test it with top-level navigations, >>>> but can we test it for iframe navigations? The way I understand >>>> https://github.com/whatwg/html/pull/11454 iframe navs should also get >>>> the new behavior. >>>> >>> >>> You can also test top-level navigations by opening popup windows. There >>> are helpful frameworks for writing such tests, e.g., RemoteContextHelper >>> <https://github.com/search?q=repo%3Aweb-platform-tests%2Fwpt%20RemoteContextHelper&type=code> >>> . >>> >> >> WPT uses popups extensively to test features that rely on top-level >> navigation. Navigation timing, render-blocking, cross-document view >> transitions come to mind as reference. >> >> > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/17c109d3-e84f-4fdc-a755-c7020c7215e9n%40chromium.org.
