We've definitely gotten set_test_context() to work in the past; e.g. here is a CL <https://chromium-review.googlesource.com/c/chromium/src/+/6497897> that works (see executor.sub.html in particular, and some of the comments debugging earlier mistakes we made). But I also remember it being tricky.
+Jonathan Lee <[email protected]> was able to help us with that test, and might be able to provide guidance if the sample CL above isn't enough. On Wed, Sep 17, 2025 at 5:18 AM Mustaq Ahmed <[email protected]> wrote: > Because of a testdriver limitation we can't add a WPT at this point. The > test would require a click in the main window to open a popup w, then a > click on w to navigate the popup away. Unfortunately, testdriver does > not yet support both the clicks: test_driver.set_test_context(w) fails to > switch the context to w, and without it a test_drive.click() on w is > rejected and a test_driver.Actions.send() on w is ignored. > > Here is a prototype test > <https://chromium-review.googlesource.com/c/chromium/src/+/6956519>, the > problems are mentioned in the main test comment. > > On Mon, Sep 8, 2025 at 2:32 PM Chris Harrelson <[email protected]> > wrote: > >> LGTM3 >> >> On Mon, Sep 8, 2025 at 11:31 AM 'Dan Clark' via blink-dev < >> [email protected]> wrote: >> >>> LGTM2, also conditional on tests being added. Thanks for getting >>> position requests filed ( >>> https://github.com/mozilla/standards-positions/issues/1295, >>> https://github.com/WebKit/standards-positions/issues/547). >>> -- Dan >>> >>> On Wednesday, September 3, 2025 at 7:16:05 AM UTC-7 >>> [email protected] wrote: >>> >>>> LGTM1, conditional on the testing situation getting sorted to Dan and >>>> Domenic's satisfaction. >>>> >>>> Best, >>>> >>>> Alex >>>> >>>> On Wednesday, September 3, 2025 at 10:29:22 AM UTC+1 Noam Rosenthal >>>> wrote: >>>> >>>>> On Wed, Sep 3, 2025 at 1:59 AM Domenic Denicola <[email protected]> >>>>> wrote: >>>>> >>>>>> >>>>>> >>>>>> On Wed, Sep 3, 2025 at 9:04 AM 'Daniel Clark' via blink-dev < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> > I believe in WPT we can't have an a.html top-frame navigate to >>>>>>> b.html and check things there. I was not able to find an example in >>>>>>> wpt/navigation-api/. Did I miss anything? >>>>>>> >>>>>>> >>>>>>> >>>>>>> I think it’s correct that we can’t test it with top-level >>>>>>> navigations, but can we test it for iframe navigations? The way I >>>>>>> understand https://github.com/whatwg/html/pull/11454 iframe navs >>>>>>> should also get the new behavior. >>>>>>> >>>>>> >>>>>> You can also test top-level navigations by opening popup windows. >>>>>> There are helpful frameworks for writing such tests, e.g., >>>>>> RemoteContextHelper >>>>>> <https://github.com/search?q=repo%3Aweb-platform-tests%2Fwpt%20RemoteContextHelper&type=code> >>>>>> . >>>>>> >>>>> >>>>> WPT uses popups extensively to test features that rely on top-level >>>>> navigation. Navigation timing, render-blocking, cross-document view >>>>> transitions come to mind as reference. >>>>> >>>>> >>>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/17c109d3-e84f-4fdc-a755-c7020c7215e9n%40chromium.org >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/17c109d3-e84f-4fdc-a755-c7020c7215e9n%40chromium.org?utm_medium=email&utm_source=footer> >>> . >>> >> -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM0wra9urM96bwQTX%3DBsDzuWLwn1k7AuyzMyuGBvemqRJs2ZhA%40mail.gmail.com.
