For those that are interested in what I meant by the last remark, I believe that this is the logged out view:

https://issues.apache.org/bloodhound/raw-attachment/ticket/42/Is%20the%20Create%20Ticket%20button%20disabled.png

If there was the context of other active buttons of the same type it might not be so bad. At the moment I have visions of lots of frustrated people clicking the button and wondering why nothing is happening! What if we just drop the btn-primary class too?

Cheers,
    Gary


On 04/27/2012 05:46 PM, Gary wrote:
Hi Olemis,

Sorry.. keeping it open for now. In my follow-up comment I've suggested a small fix due to an odd change in the shape of the button when removing the dropdown-toggle class. I also ponder whether the button really looks disabled.

Cheers,
    Gary


On 04/27/2012 03:46 PM, Olemis Lang wrote:
afaics , once patch applied , this ticket should be closed .

On 4/27/12, Apache Bloodhound<[email protected]> wrote:
#42: Disable quick ticket button when user doesn't have sufficient
permission
--------------------------+-------------------------------------
   Reporter:  jdreimann    |      Owner:  olemis
       Type:  enhancement  |     Status:  accepted
   Priority:  major        |  Milestone:  RC1 for initial release
  Component:  dashboard    |    Version:
Resolution:               |   Keywords:
--------------------------+-------------------------------------
Changes (by olemis):

  * status:  new =>  accepted
  * owner:  nobody =>  olemis


Comment:

[attachment:t42_r1328689_disable_qct_perms.diff Attached patch] built on
  top of r1328689 implements this feature .

  My patch queue looks like this . Beware of the order to apply them
  ''';)''' on top of [attachment:ticket:39:t39_r1328689_indexerror.diff
patch for #39] and [attachment:ticket:23:t23_r1328689_flexible_qct.diff patch for #23] applied on top of r1328689 (which is a rather old version ,
  but I thought I'd better submit these as soon as possible)

  {{{
  #!sh

  $ hg qapplied
  t39/t39_r1328689_indexerror.diff
  t23/t23_r1328689_flexible_qct.diff
  t42/t42_r1328689_disable_qct_perms.diff
  }}}

--
Ticket URL:<https://issues.apache.org/bloodhound/ticket/42#comment:1>
Apache Bloodhound<https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker




Reply via email to