OK, the simplest solution that might satisfy the most people may well be
to check for sufficient permissions and provide an appropriate
explanation in the drop down.
So I think Olemis means:
* Fails permission check and is anonymous: "You do not have
sufficient permissions to create a ticket. Please <a>Login</a>."
* Fails permission check and is not anonymous: "Your account does not
have sufficient permissions to create a ticket. Ask your
administrator for more information."
or something like that. Generally, asking a logged in user to login with
a different account will probably be futile.
I haven't checked all the different ways that login can be achieved but
I assume that it is possible to get the relevant link from either trac
or the account manager plugin.
Will that do for now?
Cheers,
Gary
On 28/04/12 23:55, Olemis Lang wrote:
very good point
I'd rather move forward with the second one (i.e. "You don't have
sufficient permissions to create a ticket here ...) *AND* if
req.authname != anonymous then insert a Login link rather than login
form as it turns out that some login mechanisms do not use web forms
at all (e.g. http basic auth , digest auth , ntlm , ...)
On 4/28/12, Joe Dreimann<[email protected]> wrote:
Maybe click and/or hover on the disabled button should show a tooltip asking
to log in? For now.
The better solution would be to not disable the button at all, but change
the drop down from the normal quick ticket one to "You need to log in to
create a ticket here" with login boxes (UN/PWD) or when logged in already:
"You don't have sufficient permissions to create a ticket here. Please
contact your<admin/team leader> to request these.<contact details>
Ultimately this is a better solution than disabling the button, but it's a
question of whiter this needs to be a v1 implementation. The disabled button
is a poor experience, but *may* be sufficient for RC1 if the better solution
takes too long to implement.
- Joe
________________________
@jdreimann - Twitter
Sent from my phone
On 27 Apr 2012, at 18:16, Gary<[email protected]> wrote:
For those that are interested in what I meant by the last remark, I
believe that this is the logged out view:
https://issues.apache.org/bloodhound/raw-attachment/ticket/42/Is%20the%20Create%20Ticket%20button%20disabled.png
If there was the context of other active buttons of the same type it might
not be so bad. At the moment I have visions of lots of frustrated people
clicking the button and wondering why nothing is happening! What if we
just drop the btn-primary class too?
Cheers,
Gary
On 04/27/2012 05:46 PM, Gary wrote:
Hi Olemis,
Sorry.. keeping it open for now. In my follow-up comment I've suggested a
small fix due to an odd change in the shape of the button when removing
the dropdown-toggle class. I also ponder whether the button really looks
disabled.
Cheers,
Gary
On 04/27/2012 03:46 PM, Olemis Lang wrote:
afaics , once patch applied , this ticket should be closed .
On 4/27/12, Apache Bloodhound<[email protected]>
wrote:
#42: Disable quick ticket button when user doesn't have sufficient
permission
--------------------------+-------------------------------------
Reporter: jdreimann | Owner: olemis
Type: enhancement | Status: accepted
Priority: major | Milestone: RC1 for initial release
Component: dashboard | Version:
Resolution: | Keywords:
--------------------------+-------------------------------------
Changes (by olemis):
* status: new => accepted
* owner: nobody => olemis
Comment:
[attachment:t42_r1328689_disable_qct_perms.diff Attached patch] built
on
top of r1328689 implements this feature .
My patch queue looks like this . Beware of the order to apply them
''';)''' on top of [attachment:ticket:39:t39_r1328689_indexerror.diff
patch for #39] and
[attachment:ticket:23:t23_r1328689_flexible_qct.diff
patch for #23] applied on top of r1328689 (which is a rather old
version ,
but I thought I'd better submit these as soon as possible)
{{{
#!sh
$ hg qapplied
t39/t39_r1328689_indexerror.diff
t23/t23_r1328689_flexible_qct.diff
t42/t42_r1328689_disable_qct_perms.diff
}}}
--
Ticket URL:<https://issues.apache.org/bloodhound/ticket/42#comment:1>
Apache Bloodhound<https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker