Interesting. In that case, I will suggest that we always attach patches to tickets and refer to them as you have done here. For the smallest of patches, you can also choose to paste the text directly into an email - or indeed into a ticket comment as I did recently for #204. I will put this into a wiki page shortly.

As for the patch, it looks like good work to me. Unless anyone else notices any problems I expect to commit it a bit later tonight.

Meanwhile Peter, if you were happy with all that, I can't see a problem with you taking on another ticket if you want to and you have time. I'd be happy to try to suggest one but you should feel free to look through the list Joe created at https://issues.apache.org/bloodhound/wiki/BloodhoundContributing and assign yourself one you think would be interesting.

Cheers,
    Gary


On 09/19/2012 04:12 PM, Peter Koželj wrote:
So, it seems that my attached patch got stripped.

I have now added it to the ticket itself:
https://issues.apache.org/bloodhound/attachment/ticket/187/ticket-187.diff

Cheers,
Peter

On Wed, Sep 19, 2012 at 2:03 PM, Peter Koželj <[email protected]> wrote:

Hi,

attached is a patch that I am proposing. It removes the paginator but
leaves the total ticket number as is.
Any changes to the "More" link and total tickets number should probably be
addressed separately.

Peter

On Wed, Sep 19, 2012 at 1:47 PM, Joachim Dreimann <
[email protected]> wrote:

I agree with displaying the total number - the More link could show "32
More" for example to indicate how many more tickets there will be.
Alternatively we could show something like:

More  42 Total

I believe we should always show the more link though, not just
conditionally. It stands not just for 'more tickets', but also represents
'more query options', 'more filtering' etc - functionality that we may not
want to duplicate on the Dashboard, and at least won't in the short term.

Cheers,
Joe

On 19 Sep 2012, at 12:22, Gary Martin <[email protected]> wrote:

I agree that a user might want to know the total number of tickets that
are matching the query. I have not seen that feature in any mock-ups
though. As it was Joe's request, I hope he might comment on this aspect.
Meanwhile thanks for the note about the "More" link. Discussions of
this may overlap a little with #190 which Jure is looking at. On the other
hand, I don't think that point is covered by #190 so I would probably
encourage you to raise a new ticket.
As for a possible answer to it: I don't suppose it would be missed if
the "More" link was shown conditionally. Although it could be considered
useful as a link to the appropriate query, the alternative of changing the
link text may just be confusing.
Cheers,
    Gary


On 09/19/2012 11:26 AM, Peter Koželj wrote:
I'll just remove it then.

Another question: The task says we should remove total ticket number as
well. Is that correct?
Information about a number of all tickets seem useful.

And a note: Should the "More" link really be there when there is less
than
max number of tickets?

Cheers,
Peter

On Wed, Sep 19, 2012 at 12:03 PM, Gary Martin <
[email protected]>wrote:
If there is a way for the paginator to make sense we could consider
keeping the code. I think it would only make sense if it updated the
tickets shown on the same page but it is not clear that we want that
at the
moment.

I would lean towards the second option. Although it might be
annoying, it
could always be reverted and adapted to a future behaviour.

Cheers,
Gary



On 09/19/2012 10:52 AM, Peter Koželj wrote:

There are two ways we can do this.

1. We can add a "show_paginator" argument to the TicketQueryWidget
and set
it to False for every widget instance on dashboard.
     The plus side is that this leaves as with the option to have both
style
instances of the widget.
     The negative side is that we keep some dead code if we never use
the
option with shown paginator.

2. The simple solution is to simply remove the pagination stuff from
the
widget_grid.html.
      As far as I can tell, the widget is not used outside the
dashboard
anyway.

Peter

On Tue, Sep 18, 2012 at 1:18 PM, Apache Bloodhound <
bloodhound-dev@incubator.**apache.org<
[email protected]>>
wrote:

  #187: Remove row count and results pagination from Dashboard
--------------------------+---**-------------------
    Reporter:  jdreimann    |      Owner:  peter
        Type:  enhancement  |     Status:  assigned
    Priority:  minor        |  Milestone:
   Component:  dashboard    |    Version:
Resolution:               |   Keywords:
--------------------------+---**-------------------
Changes (by gjm):

   * status:  new => assigned
   * owner:  nobody => peter


--
Ticket URL: <
https://issues.apache.org/**bloodhound/ticket/187#comment:*
*3 <https://issues.apache.org/bloodhound/ticket/187#comment:3>>
Apache Bloodhound <https://issues.apache.org/**bloodhound/<
https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker




Reply via email to