Hi Kevin,
i had no time so far to test this and i'm not at my computer, so just
a quick look and some short comments.
1. It looks good :)
2. Maybe you should add your name as author and a link to you to the
comments at top.
3. You could make some inline comments like /* Margin part starts here
*/ /* Padding part starts here */
4. Please add some white space in your uncompressed file .class-name
{ margin-top: XYem; } is much better readable. If you use blueprint
you'll finally compress all your files, so you can add stuff for
readability without a problem.
Q.:
A.1. Have you tested this with some common elements and how it affects
the vertical rhytm or the grid? Maybe you could provide a test-link...
A.2. Have you tested what happens if you add your classes to some
element and add some from the blueprint to the following element? You
should be aware, that your classes will "kill" the grid and that you
should think about something that brings the rest of the page back
into the rhytm & grid. You could take a look at the .colborder class
for an example.
B. I have seen that you still got stuff like .pr-200 class, which is
the exact same as the .append-1 class in the grid.css core file.
Please strip such classes out.
Wish you best!
--
You received this message because you are subscribed to the Google Groups
"Blueprint CSS" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/blueprintcss?hl=en.
