Yes, almost certainly so. Let's see... Can you change the pattern I
gave you to this:
preg_match_all('/\[\[([^{}:&#|@\/\]]+)(\&|\#|\||\])/',
$content, $links);
Engine.php, 1249. It is not exhaustive, but it might be enough to get
us through most issues. We can perfect it more later if we have
specific issues come up...
Cheers,
Dan
On Mon, Oct 19, 2009 at 12:47 PM, Markus <[email protected]> wrote:
>
> And external links too.
>
> And for example one of the {p} links on code.snippets.
>
> And maybe more. Caused by the fix you gave me above? I just noticed
> all these "broken" links after I deleted my index. Somehow they didn't
> show up before although I have [(index)] in my footer.
>
> On Oct 19, 6:35 pm, Markus <[email protected]> wrote:
>> Link Rot detects
>>
>> [[[email protected]]]
>>
>> as a broken link.
>>
>> Regards, Markus
>>
>> On Oct 19, 4:16 pm, Markus <[email protected]> wrote:
>>
>>
>>
>> > I'll celebrate the day when we have a revision control system. I get
>> > crazy copying crumbled email code into source files. Line breaks,
>> > spaces, indentation... ouch! :)
>>
>> > Link Rot is now working with utf-8 links, well done!
>>
>> > Regards,
>> > Markus
>>
>> > On Oct 19, 3:38 pm, The Editor <[email protected]> wrote:
>>
>> > > Ok, I see it now. The problem is not the linkrot plugin actually--but
>> > > the indexing. Several problems actually--including you can't search
>> > > for a page name with utf, or use link= for utf links. The linkrot
>> > > plugin simply uses the index, so if it's wrong so will be it's output.
>>
>> > > Specifically:
>>
>> > > The page name when inserted into the indexed content is url encoded,
>> > > when it should be utf.
>>
>> > > UTF links are not getting indexed at all.
>>
>> > > And once indexed, they needed to be changed to url for the search to
>> > > work.
>>
>> > > This will be fixed in the next release, but if you can't wait, try
>> > > pasting the following code over engine.php ~1255. I put * by the lines
>> > > that were changed...
>>
>> > > * if (strpos($BOLTindexPlus, 'page') !== false)
>> > > $content =
>> > > BOLTurl2utf($p) . " $content ";
>> > > if (strpos($BOLTindexPlus, 'data') === false)
>> > > $content =
>> > > substr($content, 0, strpos($content, "\n~data~\n"));
>> > > }
>> > > // index links
>> > > * preg_match_all('/\[\[([^&|\]]+)(\&|\||\])/', $content,
>> > > $links);
>> > > $linksArray = array_unique($links[1]);
>> > > $mylinks = implode("<>", $linksArray);
>> > > * $mylinks = BOLTutf2url(str_replace('~', "$loginPages.",
>> > > $mylinks));
>>
>> > > You will have to reindex your site of course, to get everything up to
>> > > speed....
>>
>> > > Cheers,
>> > > Dan
>>
>> > > On Mon, Oct 19, 2009 at 12:55 AM, Markus <[email protected]>
>> > > wrote:
>>
>> > > > On Oct 18, 11:50 pm, The Editor <[email protected]> wrote:
>> > > >> On Sun, Oct 18, 2009 at 7:14 AM, Markus
>> > > >> <[email protected]> wrote:
>>
>> > > >> > Link Rot does not support utf-8 page names. I'd be glad if it gets
>> > > >> > fixed sometime.
>>
>> > > >> Can you explain exactly what is happening. That will help me to debug
>> > > >> it....
>>
>> > > > Hm. Sorry, not much to explain. If you have a broken link to a page
>> > > > containing characters like 'äöü' etc. that link will not be listed as
>> > > > broken although it is.
>>
>> > > >> Cheers,
>> > > >> Dan
> >
>
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"BoltWire" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/boltwire?hl=en
-~----------~----~----~----~------~----~------~--~---
