On Nov 23, 2011, at 9:39 PM, Ivan Kelly wrote:


BOOKKEEPER-111 Document bookie recovery feature
BOOKKEEPER-110 Review documentation
BOOKKEEPER-62 Bookie can not start when encountering corrupted records BOOKKEEPER-112 Bookie Recovery on an open ledger will cause LedgerHandle#close on that ledger to fail


I agree that these should be in.

The following are patch available at the moment, so they should be in the release also.

BOOKKEEPER-39 Bookie server failed to restart because of too many ledgers (more than ~50,000 ledgers) BOOKKEEPER-117 Support multi threads in hedwig cpp client to leverage multi-core hardware BOOKKEEPER-118 Hedwig client doesn't kill and remove old subscription channel after redirection.


I would say that if there is no contention on the patch and the fix is critical, then we should hold the release until they are fixed. Here is the status I see for each jira:

BOOKKEEPER-39: You had comments there, Ivan, could you give it another review? BOOKKEEPER-117: It doesn't look strictly necessary, since it is a performance issue, but if the patch is reasonable, we could consider having it. BOOKKEEPER-118: The patch there seems to be preliminary, but the issue seems critical, though.

There a final set, which are marked for 4.0.0. I haven't gone through these in detail, but I think they could all be postponed to 4.1.0 if necessary. BOOKKEEPER-53 race condition of outstandingMsgSet@SubscribeResponseHandler
BOOKKEEPER-72 Fix warnings issued by FindBugs
BOOKKEEPER-55 SubscribeReconnectRetryTask might retry subscription endlessly when another subscription is already successfully created previously BOOKKEEPER-56 Race condition of message handler in connection recovery in Hedwig client


Aside from 72, all others seem serious enough. Do you think these races are not serious enough?

-Flavio


flavio
junqueira

research scientist

[email protected]
direct +34 93-183-8828

avinguda diagonal 177, 8th floor, barcelona, 08018, es
phone (408) 349 3300    fax (408) 349 3301

Reply via email to