Replies inline. I spoke with Sijie this morning and reminded me about the change to keep performance constant regardless of number of ledgers. I think this should go in too, since we have the code. > BOOKKEEPER-39: You had comments there, Ivan, could you give it another > review? > BOOKKEEPER-117: It doesn't look strictly necessary, since it is a > performance issue, but if the patch is reasonable, we could consider > having it. > BOOKKEEPER-118: The patch there seems to be preliminary, but the issue > seems critical, though. Going to look at them today.
> >> There a final set, which are marked for 4.0.0. I haven't gone >> through these in detail, but I think they could all be postponed to >> 4.1.0 if necessary. >> BOOKKEEPER-53 race condition of >> outstandingMsgSet@SubscribeResponseHandler >> BOOKKEEPER-72 Fix warnings issued by FindBugs >> BOOKKEEPER-55 SubscribeReconnectRetryTask might retry subscription >> endlessly when another subscription is already successfully created >> previously >> BOOKKEEPER-56 Race condition of message handler in connection >> recovery in Hedwig client >> > > Aside from 72, all others seem serious enough. Do you think these > races are not serious enough? Im not sure. I have a todo in my list to look at these for the last week, but haven't got around to it yet. -Ivan
