[
https://issues.apache.org/jira/browse/BOOKKEEPER-197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245136#comment-13245136
]
Flavio Junqueira commented on BOOKKEEPER-197:
---------------------------------------------
This patch looks mostly ok to me, except that the log statement following the
new ZooKeeper(...) call seems to be using the wrong values. I also don't have
it clear if this assignment still makes sense "this.bkClientConf = bkConf;". I
haven't checked trunk, so the comment about the assignment could be wrong.
> HedwigConsole uses the same file to load bookkeeper client config and hub
> server config
> ---------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-197
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-197
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.1.0
> Reporter: Aniruddha
> Assignee: Sijie Guo
> Priority: Minor
> Fix For: 4.1.0
>
> Attachments: BK-197.diff, BK-197.diff_v2
>
>
> In the current implementation of HedwigConsole.java, The same server-cfg file
> (default = hedwig-server/conf/hw_server.conf) is used to load both
> hubServerConf and bkClientConf. This seems incorrect because both have
> different option names.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
