[
https://issues.apache.org/jira/browse/BOOKKEEPER-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426686#comment-13426686
]
Uma Maheswara Rao G commented on BOOKKEEPER-246:
------------------------------------------------
I have a few comments on API names in LedgerUnderreplicationManager.
- markLedgerComplete --> markLedgerReplicated where as we already have an API
markLedgerUnderreplicated.
- releaseLedger --> releaseLedgerFromRereplication where as we already have an
API getLedgerToRereplicate.
or we can just have like, getUnderReplicatedLedger,
releaseUnderReplicatedLedger and mainly this apis deals with the aquiring locks
on underReplicated ledgers.
- now we can remove ReplicationException from this patch as BK-317 committed.
- heldLocks.put(ledgerId, new Lock(lockPath, stat.getVersion()));
Why we are trying maintaining the multiple locks. We have decided one Bookie
will do only one ledger replication at a time right?
So, in that case when we will have multiple heldlocks with diff ledger ids
with one ReplicationWorker service?
- most of the code in testCompletion & testRelease is duplicated.
- It would be great if you add some javadoc in tests
- can we please move getNewZooKeeper methods to ZookeeperUtil class and
refactor the code in ZookeeperUtil that has the similar logic already in
startSever if you want to pass diff arguments etc.
Thanks,
Uma
> Recording of underreplication of ledger entries
> -----------------------------------------------
>
> Key: BOOKKEEPER-246
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-246
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-client, bookkeeper-server
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-246.diff, BOOKKEEPER-246.diff,
> BOOKKEEPER-246.diff
>
>
> This JIRA is to decide how to record that entries in a ledger are
> underreplicated.
> I think there is a common understanding (correct me if im wrong), that
> rereplication can be broken into two logically distinct phases. A) Detection
> of entry underreplication & B) Rereplication.
> This subtask is to handle the interaction between these two stages. Stage B
> needs to know what to rereplicate; how should Stage A inform it?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
