[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433147#comment-13433147
 ] 

Uma Maheswara Rao G commented on BOOKKEEPER-246:
------------------------------------------------

One clarification, this close API will not solve Rakesh point right?
Becasue, real lock node presents but, it got removed by heldLocks map.

But close is iterating over heldLocks and trying to call delete on them. 
Ingeneral this is fine. Once keeperException comes from release API, worker may 
try to close the replication manager. But that destroy will not really delete 
that lock node right? ( infact subsequent calls also may fail with 
KeeperException).

In releaseUnderreplicatedLedger, how about delete first and in finally remove 
from the heldLocks map?

Please correct me, If I miss something here.
                
> Recording of underreplication of ledger entries
> -----------------------------------------------
>
>                 Key: BOOKKEEPER-246
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-246
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: bookkeeper-client, bookkeeper-server
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-246.diff, BOOKKEEPER-246.diff, 
> BOOKKEEPER-246.diff, BOOKKEEPER-246.diff, BOOKKEEPER-246.diff
>
>
> This JIRA is to decide how to record that entries in a ledger are 
> underreplicated. 
> I think there is a common understanding (correct me if im wrong), that 
> rereplication can be broken into two logically distinct phases. A) Detection 
> of entry underreplication & B) Rereplication. 
> This subtask is to handle the interaction between these two stages. Stage B 
> needs to know what to rereplicate; how should Stage A inform it?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to