[ https://issues.apache.org/jira/browse/BOOKKEEPER-529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544733#comment-13544733 ]
Fangmin Lv commented on BOOKKEEPER-529: --------------------------------------- Good patch, lgtm +1, with this patch we can obviously reduce memory leak, it has been verified on our production environment(only 8G memory was used while others 12G after two days running). > stopServingSubscriber in delivery manager should remove stub callbacks in > ReadAheadCache > ---------------------------------------------------------------------------------------- > > Key: BOOKKEEPER-529 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-529 > Project: Bookkeeper > Issue Type: Improvement > Components: hedwig-server > Reporter: Sijie Guo > Assignee: Sijie Guo > Fix For: 4.3.0 > > Attachments: BOOKKEEPER-529.diff > > > Currently each subscriber would insert stub callback to wait newly published > messages or scanning result. for waiting scan result, it was OK. the callback > would be triggered and removed after scan callback arrived. but if it was > wait newly published, it would be a problem. if sub/closesub/sub become > frequent, closesub doesn't remove the installed callback, so the stub > callbacks are accumulated, which cause the memory increased, finally OOM. > it would be better to remove its installed stub callback when closesub. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira