[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547728#comment-13547728
 ] 

Hadoop QA commented on BOOKKEEPER-529:
--------------------------------------

Testing JIRA BOOKKEEPER-529


Patch 
[BOOKKEEPER-529.diff|https://issues.apache.org/jira/secure/attachment/12563896/BOOKKEEPER-529.diff]
 downloaded at Wed Jan  9 07:11:24 UTC 2013

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 
120
.    {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 FINDBUGS{color}
.    {color:green}+1{color} the patch does not seem to introduce new Findbugs 
warnings
{color:green}+1 TESTS{color}
.    Tests run: 783
{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/bookkeeper-trunk-precommit-build/222/
                
> stopServingSubscriber in delivery manager should remove stub callbacks in 
> ReadAheadCache
> ----------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-529
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-529
>             Project: Bookkeeper
>          Issue Type: Improvement
>          Components: hedwig-server
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-529.diff, BOOKKEEPER-529.diff
>
>
> Currently each subscriber would insert stub callback to wait newly published 
> messages or scanning result. for waiting scan result, it was OK. the callback 
> would be triggered and removed after scan callback arrived. but if it was 
> wait newly published, it would be a problem. if sub/closesub/sub become 
> frequent, closesub doesn't remove the installed callback, so the stub 
> callbacks are accumulated, which cause the memory increased, finally OOM.
> it would be better to remove its installed stub callback when closesub.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to