[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627016#comment-13627016
 ] 

Ivan Kelly commented on BOOKKEEPER-564:
---------------------------------------

The bridge between journal and ledger storage is the bookie, which uses both. 
Take a look at the last patch I posted. The sync thread as we know it has gone 
away completely. InterleavedLedgerStorage has an executor on which it runs 
checkpoints, and it also take care of storing the log mark. All the running, 
and flushing flag stuff that was in the SyncThread is taken care of by the 
executor.

The log mark is a property of the ledger storage, as it defines how much of the 
history is contained within it. Therefore, it belongs there. Also, it is stored 
to the ledger dirs, which are now only written to by ledger storage.

With the patch I attached, Journal and LedgerStorage are completely decoupled. 
The only thing they have in common is the LogMark objects, which I should be 
possible to make completely opaque to the LedgerStorage in future if needed.
                
> Better checkpoint mechanism
> ---------------------------
>
>                 Key: BOOKKEEPER-564
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-564
>             Project: Bookkeeper
>          Issue Type: Improvement
>          Components: bookkeeper-server
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.3.0
>
>         Attachments: 0001-BOOKKEEPER-564-Better-checkpoint-mechanism.patch, 
> 0001-BOOKKEEPER-564-Better-checkpoint-mechanism.patch, 
> 0002-BOOKKEEPER-564-Better-checkpoint-mechanism.patch, BOOKKEEPER-564.patch, 
> BOOKKEEPER-564.patch
>
>
> Currently, SyncThread made a checkpoint too frequently, which affects 
> performance. data is writing to entry logger file might be blocked by syncing 
> same entry logger file, which affect bookie to achieve higher throughput. We 
> could schedule checkpoint only when rotating an entry log file. so new 
> incoming entries would be written to newer entry log file and old entry log 
> file could be synced.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to