[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627577#comment-13627577
]
Ivan Kelly commented on BOOKKEEPER-564:
---------------------------------------
{quote}
you didn't answer the question for skiplist based ledger storage. this is my
concern on your latest patch on previous comment.
{quote}
I assume you mean "it allows plugging different implementation for either
journal or ledger storage, at least for skip list based ledger storage.".
Moving the sync thread out of Bookie makes supporting different implementations
much easier, as Journal and LedgerStorage know absolutely nothing about each
other now, and the LedgerStorage has 100% control over when it runs a
checkpoint.
{quote}
don't you think the opaque thing is already addressed by CheckPoint interface?
{quote}
opacity yes. I was referring to something like what Checkpoint interface does
in that regard. However, it also has the #checkpointComplete() which I found
unnecessary once the storage of LogMark was moved into the LedgerStorage.
> Better checkpoint mechanism
> ---------------------------
>
> Key: BOOKKEEPER-564
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-564
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.3.0
>
> Attachments: 0001-BOOKKEEPER-564-Better-checkpoint-mechanism.patch,
> 0001-BOOKKEEPER-564-Better-checkpoint-mechanism.patch,
> 0002-BOOKKEEPER-564-Better-checkpoint-mechanism.patch, BOOKKEEPER-564.patch,
> BOOKKEEPER-564.patch
>
>
> Currently, SyncThread made a checkpoint too frequently, which affects
> performance. data is writing to entry logger file might be blocked by syncing
> same entry logger file, which affect bookie to achieve higher throughput. We
> could schedule checkpoint only when rotating an entry log file. so new
> incoming entries would be written to newer entry log file and old entry log
> file could be synced.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
