[
https://issues.apache.org/jira/browse/BOOKKEEPER-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719262#comment-13719262
]
Sijie Guo commented on BOOKKEEPER-654:
--------------------------------------
thanks for updating.
1. in OrderedSafeExecutor, why not just catch the rejected exception rather
than adding an extra boolean flag. since this flag doesn't avoid throwing
rejected exception.
2. in LedgerOpenOp, why we need #readComplete here? an unscheduled speculative
task doesn't affect any logic.
{code}
+ try {
+ speculativeTask = scheduler.scheduleWithFixedDelay(
+ speculativeReadRunnable, speculativeReadTimeout,
+ speculativeReadTimeout, TimeUnit.MILLISECONDS);
+ } catch (RuntimeException e) {
+ if (lh.bk.bookieClient.isClosed()) {
+ cb.readComplete(BKException.Code.BkClientClosedException,
+ lh, PendingReadOp.this, PendingReadOp.this.ctx);
+ return;
+ }
+ }
{code}
> Bookkeeper client operations are allowed even after its closure, bk#close()
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-654
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-654
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client
> Affects Versions: 4.2.0
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.2.2, 4.3.0
>
> Attachments: 0001-BOOKKEEPER-654-testcase-to-understand-more.patch,
> 0002-BOOKKEEPER-654.patch, 0003-BOOKKEEPER-654.patch
>
>
> User can perform below operations with the closed bookkeeper client, which
> was instantiated with external zkclient.
> - open a closed ledger
> - create a new ledger
> Also, ledgerhandle operations like fencing/add/write are infinitely hanging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
