[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13721539#comment-13721539
 ] 

Rakesh R commented on BOOKKEEPER-654:
-------------------------------------

bq.so you still need to catch exceptions.
I'm misunderstood about the exception handling in your comments. It would be 
good if you can give some more clarity.
Are you pointing me to have exception handling of OrderedSafeExecutor#submit 
OrderedSafeExecutor#submitOrdered like:
{code}
public void submit(SafeRunnable r) throws BKException{
    try{
        chooseThread().submit(r);
    catch(Exception e){
       if(isShutdown){
           throw BKClientClosedException("Bookkeeper client is CLOSED!");
       }
       throw e;
    }
}
public void submitOrdered(Object orderingKey, SafeRunnable r) throws 
BKException{
    try{
        chooseThread(orderingKey).submit(r);
    catch(Exception e){
       if(isShutdown){
           throw BKClientClosedException("Bookkeeper client is CLOSED!");
       }
       throw e;
    }
}
{code}
                
> Bookkeeper client operations are allowed even after its closure, bk#close()
> ---------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-654
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-654
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-client
>    Affects Versions: 4.2.0
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>             Fix For: 4.2.2, 4.3.0
>
>         Attachments: 0001-BOOKKEEPER-654-testcase-to-understand-more.patch, 
> 0002-BOOKKEEPER-654.patch, 0003-BOOKKEEPER-654.patch
>
>
> User can perform below operations with the closed bookkeeper client, which 
> was instantiated with external zkclient.
> - open a closed ledger 
> - create a new ledger 
> Also, ledgerhandle operations like fencing/add/write are infinitely hanging.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to