[
https://issues.apache.org/jira/browse/BOOKKEEPER-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877181#comment-13877181
]
Sijie Guo commented on BOOKKEEPER-643:
--------------------------------------
[~ikelly]
{quote}
you've moved reads into a different set of channels so there needs to be no
synchronization in the read and write paths?
{quote}
correct.
{quote}
And also preallocation of write files (I thought I saw this somewhere before in
a patch that was pushed in, but I guess not).
{quote}
I thought I put this on better checkpoint patch. but it was removed for some
your comments.
{quote}
Why not use BufferedReadChannel's logic if the position to read is lower than
the write buffer?
{quote}
this patch is somehow generated by diffing. could we just keep this? if you
want to consolidate BufferedReadChannel & BufferedChannel read logic, could we
do it later?
{quote}
One concern I have is that FileChannels in logid2filechannel never get closed.
{quote}
they are closed. could you point where it doesn't close the channels?
> Improve concurrency of entry logger
> -----------------------------------
>
> Key: BOOKKEEPER-643
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-643
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Affects Versions: 4.2.0
> Reporter: Aniruddha
> Assignee: Aniruddha
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-643.diff, BOOKKEEPER-643.diff
>
>
> the jira is created as part of BOOKKEEPER-429 to improve concurrency of
> current bookie implementation by leverage concurrent structures.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
