[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877533#comment-13877533
 ] 

Ivan Kelly commented on BOOKKEEPER-643:
---------------------------------------



>> One concern I have is that FileChannels in logid2filechannel never get 
>> closed.
> they are closed. could you point where it doesn't close the channels?
What I mean is that they never get closed through normal operation. The only 
place I see them being closed is in #shutdown and #removeFromChannelsAndClose 
(called from removeEntryLog). So, the channels are only closed when the log is 
either deleted or the bookie shuts down. What happens if the log the system 
isn't cleaning up much? There will be loads of entrylogs, and each will be in 
this map using an FD. It may not be a huge issue, as long as the ulimit is high 
enough, but perhaps this map should be exchanged for a LRU cache.

> Improve concurrency of entry logger
> -----------------------------------
>
>                 Key: BOOKKEEPER-643
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-643
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: bookkeeper-server
>    Affects Versions: 4.2.0
>            Reporter: Aniruddha
>            Assignee: Aniruddha
>             Fix For: 4.3.0
>
>         Attachments: BOOKKEEPER-643.diff, BOOKKEEPER-643.diff, 
> BOOKKEEPER-643.diff
>
>
> the jira is created as part of BOOKKEEPER-429 to improve concurrency of 
> current bookie implementation by leverage concurrent structures.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to