-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17352/
-----------------------------------------------------------
(Updated Feb. 4, 2014, 9:07 a.m.)
Review request for bookkeeper, fpj and Ivan Kelly.
Changes
-------
address comment & add close flag in bookkeeper
Bugs: BOOKKEEPER-654
https://issues.apache.org/jira/browse/BOOKKEEPER-654
Repository: bookkeeper-git
Description
-------
the correct close sequence should be:
1) close the bookie client to error out all pending bookie requests, and after
bookie client is close, all following request would be rejected.
2) close the ledger manager which erred out all pending all metadata requests,
and after ledger manager is close, all metadata request would be rejected.
3) close scheduler.
attach a patch following this sequence.
Diffs (updated)
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java
ace1409
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
a91861c
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
c5f5233
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookieWatcher.java
cfb6022
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerChecker.java
cfb9128
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragmentReplicator.java
4a4eb49
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
bf4bd97
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java
5b8a703
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java
8f1f18a
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
6cf6c1b
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedOp.java
a077556
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/CleanupLedgerManager.java
PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieClient.java
696bcc2
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
d8ebaf6
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/OrderedSafeExecutor.java
ac068c9
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookKeeperCloseTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/17352/diff/
Testing
-------
Thanks,
Sijie Guo
