-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17352/
-----------------------------------------------------------
(Updated Feb. 10, 2014, 6:27 a.m.)
Review request for bookkeeper, fpj and Ivan Kelly.
Changes
-------
addressed Ivan' comment, removed closed flag in pcbc.
Bugs: BOOKKEEPER-654
https://issues.apache.org/jira/browse/BOOKKEEPER-654
Repository: bookkeeper-git
Description
-------
the correct close sequence should be:
1) close the bookie client to error out all pending bookie requests, and after
bookie client is close, all following request would be rejected.
2) close the ledger manager which erred out all pending all metadata requests,
and after ledger manager is close, all metadata request would be rejected.
3) close scheduler.
attach a patch following this sequence.
Diffs (updated)
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java
ace1409
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
441cff6
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
7967a82
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookieWatcher.java
744d9c6
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerChecker.java
962f3a3
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragmentReplicator.java
7329ba1
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
13d6aa7
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java
5b8a703
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java
f464ac5
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
241fdbb
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedOp.java
a077556
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/CleanupLedgerManager.java
PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieClient.java
2f447d9
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
0757f87
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/OrderedSafeExecutor.java
ac068c9
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookKeeperCloseTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/17352/diff/
Testing
-------
Thanks,
Sijie Guo
