[ https://issues.apache.org/jira/browse/BOOKKEEPER-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13909431#comment-13909431 ]
Hadoop QA commented on BOOKKEEPER-734: -------------------------------------- Testing JIRA BOOKKEEPER-734 Patch [0001-BOOKKEEPER-734_br_4_2.patch|https://issues.apache.org/jira/secure/attachment/12630483/0001-BOOKKEEPER-734_br_4_2.patch] downloaded at Sat Feb 22 16:41:30 UTC 2014 ---------------------------- {color:red}-1{color} Patch failed to apply to head of branch ---------------------------- > Improve the HashedWheelTimer usage in PerChannelBookieClient > ------------------------------------------------------------ > > Key: BOOKKEEPER-734 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-734 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-server > Affects Versions: 4.2.2 > Reporter: Rakesh R > Assignee: Rakesh R > Fix For: 4.2.3 > > Attachments: 0001-BOOKKEEPER-734_br_4_2.patch > > > Observed two potential cases about the HashedWheelTimer usage: > # Unnecessary creation of HashedWheelTimer for each channel connection > establishment. Instead of creating for each channel connection, we could > create one timer per bookie client and close it during permanent closure. > # Handle IllegalStateException of HashedWheelTimer.releaseExternalResources() -- This message was sent by Atlassian JIRA (v6.1.5#6160)