[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13909438#comment-13909438
 ] 

Rakesh R commented on BOOKKEEPER-734:
-------------------------------------

Hi Ivan/Sijie,
Attached patch is based on branch 4.2, please ignore the jenkins report. In 
trunk, this is not required as we have our own timer. Please have a look at the 
patch and would like to see the feedback. Thanks

> Improve the HashedWheelTimer usage in PerChannelBookieClient
> ------------------------------------------------------------
>
>                 Key: BOOKKEEPER-734
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-734
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-server
>    Affects Versions: 4.2.2
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>             Fix For: 4.2.3
>
>         Attachments: 0001-BOOKKEEPER-734_br_4_2.patch
>
>
> Observed two potential cases about the HashedWheelTimer usage:
> # Unnecessary creation of HashedWheelTimer for each channel connection 
> establishment. Instead of creating for each channel connection, we could 
> create one timer per bookie client and close it during permanent closure.
> # Handle IllegalStateException of HashedWheelTimer.releaseExternalResources()



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to