[ https://issues.apache.org/jira/browse/BOOKKEEPER-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944955#comment-13944955 ]
Rakesh R commented on BOOKKEEPER-582: ------------------------------------- >From my side, the changes looks fine apart from the comments present in the >review board. Also, I guess this is a common pattern everyone follows while upgrading. First it should upgrade the servers one by one and now new server should be able to serve the old client requests. Should we document this specifically anywhere ? > Make bookie and client use protobuf for requests (non-wire part) > ---------------------------------------------------------------- > > Key: BOOKKEEPER-582 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-582 > Project: Bookkeeper > Issue Type: Sub-task > Components: bookkeeper-client, bookkeeper-server > Reporter: Ivan Kelly > Assignee: Aniruddha > Fix For: 4.3.0 > > Attachments: > 0002-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch, > 0002-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch, > 0002-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch, > 0003-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch, > BOOKKEEPER-582.diff > > > Make the client and the bookie use protobufs internally. This is the first > step to using protobufs on the wire, but for the moment, BookieRequestHandler > decodes the old wire protocol into the protobuf messages. Once this is in, > enabling on the wire will be very simple, and the old manual serialization > can be made "legacy" (still supported, but deprecated). -- This message was sent by Atlassian JIRA (v6.2#6252)