[ https://issues.apache.org/jira/browse/BOOKKEEPER-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979578#comment-13979578 ]
Hadoop QA commented on BOOKKEEPER-582: -------------------------------------- Testing JIRA BOOKKEEPER-582 Patch [BOOKKEEPER-582.v3.diff|https://issues.apache.org/jira/secure/attachment/12641669/BOOKKEEPER-582.v3.diff] downloaded at Thu Apr 24 10:53:24 UTC 2014 ---------------------------- {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:green}+1 RAW_PATCH_ANALYSIS{color} . {color:green}+1{color} the patch does not introduce any @author tags . {color:green}+1{color} the patch does not introduce any tabs . {color:green}+1{color} the patch does not introduce any trailing spaces . {color:green}+1{color} the patch does not introduce any line longer than 120 . {color:green}+1{color} the patch does adds/modifies 4 testcase(s) {color:green}+1 RAT{color} . {color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} . {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings {color:green}+1 COMPILE{color} . {color:green}+1{color} HEAD compiles . {color:green}+1{color} patch compiles . {color:green}+1{color} the patch does not seem to introduce new javac warnings {color:green}+1 FINDBUGS{color} . {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings {color:green}+1 TESTS{color} . Tests run: 900 {color:green}+1 DISTRO{color} . {color:green}+1{color} distro tarball builds with the patch ---------------------------- {color:green}*+1 Overall result, good!, no -1s*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/609/ > Make bookie and client use protobuf for requests (non-wire part) > ---------------------------------------------------------------- > > Key: BOOKKEEPER-582 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-582 > Project: Bookkeeper > Issue Type: Sub-task > Components: bookkeeper-client, bookkeeper-server > Reporter: Ivan Kelly > Assignee: Aniruddha > Fix For: 4.3.0 > > Attachments: > 0002-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch, > 0002-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch, > 0002-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch, > 0003-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch, > BOOKKEEPER-582.diff, BOOKKEEPER-582.v2.diff, BOOKKEEPER-582.v3.diff > > > Make the client and the bookie use protobufs internally. This is the first > step to using protobufs on the wire, but for the moment, BookieRequestHandler > decodes the old wire protocol into the protobuf messages. Once this is in, > enabling on the wire will be very simple, and the old manual serialization > can be made "legacy" (still supported, but deprecated). -- This message was sent by Atlassian JIRA (v6.2#6252)