[
https://issues.apache.org/jira/browse/BOOKKEEPER-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982879#comment-13982879
]
Ivan Kelly commented on BOOKKEEPER-749:
---------------------------------------
A method taking a callback *and* returning anything but void make no sense. Is
it synchronous or async? This should just be synchronous, since for now it will
only be used synchronously by the replication worker. BOOKKEEPER-746 already
introduces a listLedgersToReplicate() api.
The iterator should be over longs, not strings. ledgers are identified by
longs. Likewise for the first parameter for tryLock.
> Improve LedgerUnderreplicationManager#getLedgerToRereplicate()
> --------------------------------------------------------------
>
> Key: BOOKKEEPER-749
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-749
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-auto-recovery
> Reporter: Rakesh R
> Assignee: Rakesh R
> Attachments: 00001-BOOKKEEPER-749-interface.patch
>
>
> As per the discussion in BOOKKEEPER-733,
> LedgerUnderreplicationManager#getLedgerToRereplicate having multiple
> resposibilities like : getUrLedger + acquireLock. Actually the idea of this
> JIRA is to make the interface better.
> Please see the discussion thread:
> https://issues.apache.org/jira/browse/BOOKKEEPER-733?focusedCommentId=13963072&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13963072
--
This message was sent by Atlassian JIRA
(v6.2#6252)
