[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13983116#comment-13983116
 ] 

Ivan Kelly commented on BOOKKEEPER-749:
---------------------------------------

> Instead of notifyUnderreplicationChange() and notifyLockStatusChange() flat 
> structure, I thought of seeing in a hierarchy. Feel free to choose good one

A flat structure is better here. They're no real relation between the two types 
of notification.

For notifyUnderreplicationChange() there's no real context. For lock status 
change there should be though. Waiting on any lock change is excessive, we'd 
get pounded with notifications. A RW should only wait on a single lock if it 
has gone through its list and sees no more work available.

> Improve LedgerUnderreplicationManager#getLedgerToRereplicate()
> --------------------------------------------------------------
>
>                 Key: BOOKKEEPER-749
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-749
>             Project: Bookkeeper
>          Issue Type: Improvement
>          Components: bookkeeper-auto-recovery
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>         Attachments: 00001-BOOKKEEPER-749-interface.patch
>
>
> As per the discussion in BOOKKEEPER-733, 
> LedgerUnderreplicationManager#getLedgerToRereplicate having multiple 
> resposibilities like : getUrLedger + acquireLock. Actually the idea of this 
> JIRA is to make the interface better.
> Please see the discussion thread:
> https://issues.apache.org/jira/browse/BOOKKEEPER-733?focusedCommentId=13963072&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13963072



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to