[ https://issues.apache.org/jira/browse/BOOKKEEPER-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014628#comment-14014628 ]
Hadoop QA commented on BOOKKEEPER-745: -------------------------------------- Testing JIRA BOOKKEEPER-745 Patch [0001-BOOKKEEPER-745-Fix-for-false-reports-of-ledger-unrep.patch|https://issues.apache.org/jira/secure/attachment/12647769/0001-BOOKKEEPER-745-Fix-for-false-reports-of-ledger-unrep.patch] downloaded at Sat May 31 11:11:41 UTC 2014 ---------------------------- {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:green}+1 RAW_PATCH_ANALYSIS{color} . {color:green}+1{color} the patch does not introduce any @author tags . {color:green}+1{color} the patch does not introduce any tabs . {color:green}+1{color} the patch does not introduce any trailing spaces . {color:green}+1{color} the patch does not introduce any line longer than 120 . {color:green}+1{color} the patch does adds/modifies 4 testcase(s) {color:green}+1 RAT{color} . {color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} . {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings . {color:red}WARNING{color}: the current HEAD has 23 Javadoc warning(s) {color:green}+1 COMPILE{color} . {color:green}+1{color} HEAD compiles . {color:green}+1{color} patch compiles . {color:green}+1{color} the patch does not seem to introduce new javac warnings {color:green}+1 FINDBUGS{color} . {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings {color:green}+1 TESTS{color} . Tests run: 920 {color:green}+1 DISTRO{color} . {color:green}+1{color} distro tarball builds with the patch ---------------------------- {color:green}*+1 Overall result, good!, no -1s*{color} {color:red}. There is at least one warning, please check{color} The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/646/ > Fix for false reports of ledger unreplication during rolling restarts. > ---------------------------------------------------------------------- > > Key: BOOKKEEPER-745 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-745 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-auto-recovery > Reporter: Ivan Kelly > Assignee: Ivan Kelly > Fix For: 4.3.0, 4.2.3 > > Attachments: > 0001-BOOKKEEPER-745-Fix-for-false-reports-of-ledger-unrep.patch, > 0001-Fix-for-false-reports-of-ledger-unreplication-.trunk.patch, > 0001-Fix-for-false-reports-of-ledger-unreplication-.trunk.patch, > 0002-Fix-for-false-reports-of-ledger-unreplication-.trunk.patch, > 0004-Fix-for-false-reports-of-ledger-unreplication-.trunk.patch, > 0006-Fix-for-false-reports-of-ledger-unreplicat.branch4.2.patch > > > The bug occurred because there was no check if rereplication was enabled or > not when the auditor came online. When the auditor comes online it does a > check of which bookies are up and marks the ledgers on missing bookies as > underreplicated. In the false report case, the auditor was running after each > bookie was bounced due to the way leader election for the auditor works. And > since one bookie was down since you're bouncing the server, all ledgers on > that bookie will get marked as underreplicated. -- This message was sent by Atlassian JIRA (v6.2#6252)