[ https://issues.apache.org/jira/browse/BOOKKEEPER-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014822#comment-14014822 ]
Flavio Junqueira commented on BOOKKEEPER-745: --------------------------------------------- The patch looks good to me. The latest patch does not apply to the 4.2 branch, but I noticed that there is an older patch for 4.2. Did you mean to update it? I also don't quite understand the javadoc warning in the latest QA build. Do you know why it started showing up now? > Fix for false reports of ledger unreplication during rolling restarts. > ---------------------------------------------------------------------- > > Key: BOOKKEEPER-745 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-745 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-auto-recovery > Reporter: Ivan Kelly > Assignee: Ivan Kelly > Fix For: 4.3.0, 4.2.3 > > Attachments: > 0001-BOOKKEEPER-745-Fix-for-false-reports-of-ledger-unrep.patch, > 0001-Fix-for-false-reports-of-ledger-unreplication-.trunk.patch, > 0001-Fix-for-false-reports-of-ledger-unreplication-.trunk.patch, > 0002-Fix-for-false-reports-of-ledger-unreplication-.trunk.patch, > 0004-Fix-for-false-reports-of-ledger-unreplication-.trunk.patch, > 0006-Fix-for-false-reports-of-ledger-unreplicat.branch4.2.patch > > > The bug occurred because there was no check if rereplication was enabled or > not when the auditor came online. When the auditor comes online it does a > check of which bookies are up and marks the ledgers on missing bookies as > underreplicated. In the false report case, the auditor was running after each > bookie was bounced due to the way leader election for the auditor works. And > since one bookie was down since you're bouncing the server, all ledgers on > that bookie will get marked as underreplicated. -- This message was sent by Atlassian JIRA (v6.2#6252)