[
https://issues.apache.org/jira/browse/BOOKKEEPER-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217958#comment-14217958
]
Hadoop QA commented on BOOKKEEPER-797:
--------------------------------------
Testing JIRA BOOKKEEPER-797
Patch
[codahale-stats-opstats-fix.patch|https://issues.apache.org/jira/secure/attachment/12682418/codahale-stats-opstats-fix.patch]
downloaded at Wed Nov 19 13:50:17 UTC 2014
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
120
. {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:red}-1 RAT{color}
. {color:red}-1{color} the patch seems to introduce 1 new RAT warning(s)
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:green}+1 TESTS{color}
. Tests run: 930
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/820/
> IllegalArgumentException when calling CodahaleOpStatsLogger#toOpStatsData()
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-797
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-797
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-stats
> Affects Versions: 4.3.0
> Reporter: Matthieu Morel
> Priority: Minor
> Attachments: codahale-stats-opstats-fix.patch
>
>
> The implementation of CodahaleOpStatsLogger#toOpStatsData() passes incorrect
> parameters to codahale's Snapshot#getValue method, resulting in the following
> runtime exception:
> java.lang.IllegalArgumentException: 10.0 is not in [0..1]
> at com.codahale.metrics.Snapshot.getValue(Snapshot.java:52)
> at
> org.apache.bookkeeper.stats.CodahaleOpStatsLogger.toOpStatsData(CodahaleOpStatsLogger.java:64)
> ...
> In order to pass quantiles as [0..1] values, as expected by codahale metrics
> library, we must divide parameters by 100 before passing them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
